[whimsy] branch master updated: Implement modifyTimestamp and createTimestamp

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new b1982ec  Implement modifyTimestamp and createTimestamp
b1982ec is described below

commit b1982ec7fe94e978132f55cc277194ab4ff3d88b
Author: Sebb <se...@apache.org>
AuthorDate: Mon Feb 18 18:31:24 2019 +0000

    Implement modifyTimestamp and createTimestamp
---
 lib/whimsy/asf/ldap.rb | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index f28a17e..23e400b 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1237,15 +1237,10 @@ module ASF
     end
   end
 
+  # represenation of Committee, i.e. entry in committee-info.txt
+  # includes PMCs and other committees, but does not include podlings
   class Committee < Base
-    # TODO what to do about this? Change to ou=project or drop?
-    @base = 'ou=pmc,ou=committees,ou=groups,dc=apache,dc=org'
-
-    # Date this committee was last modified in LDAP.
-    attr_accessor :modifyTimestamp
-
-    # Date this committee was initially created in LDAP.
-    attr_accessor :createTimestamp
+    @base = nil # not sure it makes sense to define base here
 
     # return committee only if it actually exists
     def self.[] name
@@ -1254,6 +1249,18 @@ module ASF
       (ASF::Committee.pmcs+ASF::Committee.nonpmcs).map(&:name).include?(name) ? committee : nil
     end
 
+    # Date this committee was last modified in LDAP.
+    # defer to Project; must have called project.preload
+    def modifyTimestamp
+      ASF::Project[name].modifyTimestamp
+    end
+
+    # Date this committee was initially created in LDAP.
+    # defer to Project; must have called project.preload
+    def createTimestamp
+      ASF::Project[name].createTimestamp
+    end
+
     # List of owners for this committee, i.e. people who are members of the
     # committee and have update access.  Data is obtained from LDAP.
     # Takes info from Project