You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/24 18:21:43 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #2373: Only invoke completed method on unknown arguments if the failure remedy is FAIL

jamesnetherton opened a new pull request #2373:
URL: https://github.com/apache/camel-quarkus/pull/2373


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #2373: Only invoke completed method on unknown arguments if the failure remedy is FAIL

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #2373:
URL: https://github.com/apache/camel-quarkus/pull/2373#issuecomment-806375063


   Converted to draft as there's something I need to check before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #2373: Only invoke completed method on unknown arguments if the failure remedy is FAIL

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #2373:
URL: https://github.com/apache/camel-quarkus/pull/2373#issuecomment-806401311


   @ppalaga Do you mind taking a second look at this. I made some tweaks:
   
   - I realised that if `on-failure` is `warn`, then you need to process all valid arguments, instead of stopping on the first invalid argument, so I fixed that.
   
   - To make the warning message output a bit friendlier, I thought it'd be best to truncate long arguments (E.g like a classpath) and abbreviate with '...'. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2373: Only invoke completed method on unknown arguments if the failure remedy is FAIL

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2373:
URL: https://github.com/apache/camel-quarkus/pull/2373#discussion_r601196891



##########
File path: integration-tests/main-command-mode/pom.xml
##########
@@ -45,6 +45,10 @@
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-timer</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-vertx-web</artifactId>

Review comment:
       Correct.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton merged pull request #2373: Only invoke completed method on unknown arguments if the failure remedy is FAIL

Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #2373:
URL: https://github.com/apache/camel-quarkus/pull/2373


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2373: Only invoke completed method on unknown arguments if the failure remedy is FAIL

Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2373:
URL: https://github.com/apache/camel-quarkus/pull/2373#discussion_r601196249



##########
File path: integration-tests/main-command-mode/pom.xml
##########
@@ -45,6 +45,10 @@
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-timer</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-vertx-web</artifactId>

Review comment:
       I guess the vertx web client is needed by the test harness.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #2373: Only invoke completed method on unknown arguments if the failure remedy is FAIL

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #2373:
URL: https://github.com/apache/camel-quarkus/pull/2373#issuecomment-806472565


   The test failure is not related - hence merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org