You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2015/01/30 02:29:01 UTC
[3/3] mesos git commit: Removed some unnecessary comments.
Removed some unnecessary comments.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/c9ba83e2
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/c9ba83e2
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/c9ba83e2
Branch: refs/heads/master
Commit: c9ba83e272f3cef087f0b8c31515f6cf91f9422d
Parents: 57e3757
Author: Benjamin Mahler <be...@gmail.com>
Authored: Thu Jan 29 17:28:31 2015 -0800
Committer: Benjamin Mahler <be...@gmail.com>
Committed: Thu Jan 29 17:28:31 2015 -0800
----------------------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp | 13 -------------
1 file changed, 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/c9ba83e2/3rdparty/libprocess/include/process/future.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/include/process/future.hpp b/3rdparty/libprocess/include/process/future.hpp
index 63c79ee..1b427fe 100644
--- a/3rdparty/libprocess/include/process/future.hpp
+++ b/3rdparty/libprocess/include/process/future.hpp
@@ -541,7 +541,6 @@ private:
Data();
~Data();
- // Clears all callbacks.
void clearAllCallbacks();
int lock;
@@ -946,13 +945,9 @@ bool Promise<T>::discard(Future<T> future)
// DISCARDED. We don't need a lock because the state is now in
// DISCARDED so there should not be any concurrent modifications.
if (result) {
- // Run onDiscarded callbacks.
internal::run(future.data->onDiscardedCallbacks);
-
- // Run onAny callbacks.
internal::run(future.data->onAnyCallbacks, future);
- // Clear all callbacks since the future is complete.
future.data->clearAllCallbacks();
}
@@ -1636,13 +1631,9 @@ bool Future<T>::set(const T& _t)
// don't need a lock because the state is now in READY so there
// should not be any concurrent modications.
if (result) {
- // Run onReady callbacks.
internal::run(data->onReadyCallbacks, *data->t);
-
- // Run onAny callbacks.
internal::run(data->onAnyCallbacks, *this);
- // Clear all callbacks since the future is complete.
data->clearAllCallbacks();
}
@@ -1669,13 +1660,9 @@ bool Future<T>::fail(const std::string& _message)
// don't need a lock because the state is now in FAILED so there
// should not be any concurrent modications.
if (result) {
- // Run onFailed callbacks.
internal::run(data->onFailedCallbacks, *data->message);
-
- // Run onAny callbacks.
internal::run(data->onAnyCallbacks, *this);
- // Clear all callbacks since the future is complete.
data->clearAllCallbacks();
}