You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/17 23:38:17 UTC
[GitHub] [trafficcontrol] rimashah25 opened a new pull request #5652: A PR check to ensure migration file added is the latest
rimashah25 opened a new pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #2471 <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
Add a migration with dates before any of the existing file and the PR check should fail.
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] I have explained why tests are unnecessary
- [x] I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
No documentation required and the check is a test in itself since it is an implementation for CI
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597276689
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -18,7 +18,7 @@
set -e
-cd traffic_ops/app/db/migrations;
+cd ../../../traffic_ops/app/db/migrations;
Review comment:
From the GitHub Action logs:
```shell
/entrypoint.sh: line 21: cd: ../../../traffic_ops/app/db/migrations: No such file or directory
```
The current working directory of GitHub Actions is the root directory of the project, so no need to `cd` out of any directories first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597283961
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,24 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE_TIME="$(git ls-tree -r --name-only HEAD | while read filename; do
+ echo "$(git log -1 --format="%ct" -- $filename)"
+done | sort | tail -n 1)"
+
Review comment:
The Dockerfile needs git:
```shell
/entrypoint.sh: line 57: git: command not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597234111
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,23 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE="$(ls -t1 | head -n 1)"
+LATEST_FILE_TIME="$(stat -f "%m%t%Sm %N" $LATEST_FILE | cut -f1)"
+
+# Get modified times in an array
+mtime_array=()
+arr=("$(ls)")
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597299483
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,24 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE_TIME="$(git ls-tree -r --name-only HEAD | while read filename; do
+ echo "$(git log -1 --format="%ct" -- $filename)"
+done | sort | tail -n 1)"
+
+# Get modified times in an array
+mtime_array=()
+arr=($(ls))
+for file in "${arr[@]}"; do
+ mtime_array+=( "$(git log --format=%ct $file)" )
+done
+mtime_length=${#mtime_array[@]}
+
+if [[ $LATEST_FILE_TIME != ${mtime_array[$mtime_length-1]} ]]; then
+ echo "ERROR: latest added file: $LATESTFILE is not in the right order" >&2;
Review comment:
🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597266386
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,23 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE="$(ls -t1 | head -n 1)"
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597071002
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,23 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE="$(ls -t1 | head -n 1)"
+LATEST_FILE_TIME="$(stat -f "%m%t%Sm %N" $LATEST_FILE | cut -f1)"
Review comment:
We don't want to check the `mtime` of these files, we want to use `git` to see when they were added to the repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597292536
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,24 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE_TIME="$(git ls-tree -r --name-only HEAD | while read filename; do
+ echo "$(git log -1 --format="%ct" -- $filename)"
+done | sort | tail -n 1)"
+
+# Get modified times in an array
+mtime_array=()
+arr=($(ls))
+for file in "${arr[@]}"; do
+ mtime_array+=( "$(git log --format=%ct $file)" )
+done
+mtime_length=${#mtime_array[@]}
+
+if [[ $LATEST_FILE_TIME != ${mtime_array[$mtime_length-1]} ]]; then
+ echo "ERROR: latest added file: $LATESTFILE is not in the right order" >&2;
Review comment:
`LATESTFILE` is never defined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597109946
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,23 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE="$(ls -t1 | head -n 1)"
+LATEST_FILE_TIME="$(stat -f "%m%t%Sm %N" $LATEST_FILE | cut -f1)"
+
+# Get modified times in an array
+mtime_array=()
+arr=("$(ls)")
Review comment:
Since this is quoted, the entire output of `ls` will be considered a single array element. So, it should be unquoted.
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,23 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE="$(ls -t1 | head -n 1)"
+LATEST_FILE_TIME="$(stat -f "%m%t%Sm %N" $LATEST_FILE | cut -f1)"
+
+# Get modified times in an array
+mtime_array=()
+arr=("$(ls)")
+for file in $arr; do
Review comment:
To iterate through `$arr`, this should be `${arr[@]}`
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,23 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE="$(ls -t1 | head -n 1)"
Review comment:
This should use `git log` to find the latest file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597283961
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,24 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE_TIME="$(git ls-tree -r --name-only HEAD | while read filename; do
+ echo "$(git log -1 --format="%ct" -- $filename)"
+done | sort | tail -n 1)"
+
Review comment:
The Docker image needs git:
```shell
/entrypoint.sh: line 57: git: command not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597281459
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -18,7 +18,7 @@
set -e
-cd traffic_ops/app/db/migrations;
+cd ../../../traffic_ops/app/db/migrations;
Review comment:
I think your comment came just when my update must have gone through. It has been resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5652: A PR check to ensure migration file added is the latest
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #5652:
URL: https://github.com/apache/trafficcontrol/pull/5652#discussion_r597237472
##########
File path: .github/actions/todb-tests/entrypoint.sh
##########
@@ -51,6 +51,23 @@ for file in "$(ls)"; do
fi
done
+# Files added must have date and name later than all existing file
+LATEST_FILE="$(ls -t1 | head -n 1)"
+LATEST_FILE_TIME="$(stat -f "%m%t%Sm %N" $LATEST_FILE | cut -f1)"
Review comment:
replaced with git log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org