You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/04/29 10:21:58 UTC
Review Request 33664: Ambari bootstrap: Premature Agent shutdown may
lead to Agent stall
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33664/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Sid Wagle.
Bugs: AMBARI-10819
https://issues.apache.org/jira/browse/AMBARI-10819
Repository: ambari
Description
-------
Removed the agent stop invocation. The agent restarts now only after all the bits have been deployed.
Diffs
-----
ambari-agent/conf/unix/ambari-agent b03a3a4cab713b0e489c3031dc68720630324b78
ambari-server/src/main/python/setupAgent.py b3825ad9fbe1b0aad75734fd58209be4086f33c6
ambari-server/src/test/python/TestSetupAgent.py 380893f08ed18a9efa03feb930f075f472aec644
Diff: https://reviews.apache.org/r/33664/diff/
Testing
-------
mvn clean test package
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [ 6.315 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.041 s]
[INFO] Ambari Web ......................................... SUCCESS [ 40.777 s]
[INFO] Ambari Views ....................................... SUCCESS [ 2.374 s]
[INFO] Ambari Admin View .................................. SUCCESS [ 10.142 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [ 1.680 s]
[INFO] Ambari Server ...................................... SUCCESS [01:48 min]
[INFO] Ambari Agent ....................................... SUCCESS [ 31.855 s]
[INFO] Ambari Client ...................................... SUCCESS [ 0.049 s]
[INFO] Ambari Python Client ............................... SUCCESS [ 0.979 s]
[INFO] Ambari Groovy Client ............................... SUCCESS [ 9.710 s]
[INFO] Ambari Shell ....................................... SUCCESS [ 0.040 s]
[INFO] Ambari Python Shell ................................ SUCCESS [ 0.440 s]
[INFO] Ambari Groovy Shell ................................ SUCCESS [ 7.227 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:50 min
[INFO] Finished at: 2015-04-29T00:49:34-07:00
[INFO] Final Memory: 85M/820M
[INFO] ------------------------------------------------------------------------
deployment on a local VM cluster -> bootstrap ok -> back to step 2 -> bootstrap ok again
Thanks,
Florian Barca
Re: Review Request 33664: Ambari bootstrap: Premature Agent shutdown
may lead to Agent stall
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33664/#review82082
-----------------------------------------------------------
Ship it!
- Jayush Luniya
On April 29, 2015, 8:21 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33664/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 8:21 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Sid Wagle.
>
>
> Bugs: AMBARI-10819
> https://issues.apache.org/jira/browse/AMBARI-10819
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed the agent stop invocation. The agent restarts now only after all the bits have been deployed.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent b03a3a4cab713b0e489c3031dc68720630324b78
> ambari-server/src/main/python/setupAgent.py b3825ad9fbe1b0aad75734fd58209be4086f33c6
> ambari-server/src/test/python/TestSetupAgent.py 380893f08ed18a9efa03feb930f075f472aec644
>
> Diff: https://reviews.apache.org/r/33664/diff/
>
>
> Testing
> -------
>
> mvn clean test package
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 6.315 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.041 s]
> [INFO] Ambari Web ......................................... SUCCESS [ 40.777 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.374 s]
> [INFO] Ambari Admin View .................................. SUCCESS [ 10.142 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 1.680 s]
> [INFO] Ambari Server ...................................... SUCCESS [01:48 min]
> [INFO] Ambari Agent ....................................... SUCCESS [ 31.855 s]
> [INFO] Ambari Client ...................................... SUCCESS [ 0.049 s]
> [INFO] Ambari Python Client ............................... SUCCESS [ 0.979 s]
> [INFO] Ambari Groovy Client ............................... SUCCESS [ 9.710 s]
> [INFO] Ambari Shell ....................................... SUCCESS [ 0.040 s]
> [INFO] Ambari Python Shell ................................ SUCCESS [ 0.440 s]
> [INFO] Ambari Groovy Shell ................................ SUCCESS [ 7.227 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:50 min
> [INFO] Finished at: 2015-04-29T00:49:34-07:00
> [INFO] Final Memory: 85M/820M
> [INFO] ------------------------------------------------------------------------
>
> deployment on a local VM cluster -> bootstrap ok -> back to step 2 -> bootstrap ok again
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33664: Ambari bootstrap: Premature Agent shutdown
may lead to Agent stall
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33664/#review82014
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Baranchuk
On Апрель 29, 2015, 8:21 д.п., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33664/
> -----------------------------------------------------------
>
> (Updated Апрель 29, 2015, 8:21 д.п.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene Chekanskiy, Jayush Luniya, Mahadev Konar, and Sid Wagle.
>
>
> Bugs: AMBARI-10819
> https://issues.apache.org/jira/browse/AMBARI-10819
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed the agent stop invocation. The agent restarts now only after all the bits have been deployed.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent b03a3a4cab713b0e489c3031dc68720630324b78
> ambari-server/src/main/python/setupAgent.py b3825ad9fbe1b0aad75734fd58209be4086f33c6
> ambari-server/src/test/python/TestSetupAgent.py 380893f08ed18a9efa03feb930f075f472aec644
>
> Diff: https://reviews.apache.org/r/33664/diff/
>
>
> Testing
> -------
>
> mvn clean test package
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ........................................ SUCCESS [ 6.315 s]
> [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.041 s]
> [INFO] Ambari Web ......................................... SUCCESS [ 40.777 s]
> [INFO] Ambari Views ....................................... SUCCESS [ 2.374 s]
> [INFO] Ambari Admin View .................................. SUCCESS [ 10.142 s]
> [INFO] Ambari Metrics Common .............................. SUCCESS [ 1.680 s]
> [INFO] Ambari Server ...................................... SUCCESS [01:48 min]
> [INFO] Ambari Agent ....................................... SUCCESS [ 31.855 s]
> [INFO] Ambari Client ...................................... SUCCESS [ 0.049 s]
> [INFO] Ambari Python Client ............................... SUCCESS [ 0.979 s]
> [INFO] Ambari Groovy Client ............................... SUCCESS [ 9.710 s]
> [INFO] Ambari Shell ....................................... SUCCESS [ 0.040 s]
> [INFO] Ambari Python Shell ................................ SUCCESS [ 0.440 s]
> [INFO] Ambari Groovy Shell ................................ SUCCESS [ 7.227 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:50 min
> [INFO] Finished at: 2015-04-29T00:49:34-07:00
> [INFO] Final Memory: 85M/820M
> [INFO] ------------------------------------------------------------------------
>
> deployment on a local VM cluster -> bootstrap ok -> back to step 2 -> bootstrap ok again
>
>
> Thanks,
>
> Florian Barca
>
>