You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/05 03:52:14 UTC

[GitHub] [cordova-docs] breautek opened a new pull request #1101: Node12

breautek opened a new pull request #1101:
URL: https://github.com/apache/cordova-docs/pull/1101


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Documentation
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Build tools stopped working on Node 12. This PR updates the build scripts to so that we can use modern Node (current LTS).
   
   ### Description
   <!-- Describe your changes in detail -->
   
   Gulp was the culprit that was breaking the build on Node12. `gulp` and `vinyl-source-stream` both had a major upgrade to support Node12. These dependencies were bumped and refactors were made as necessary.
   
   For `gulp`, this involved removing the `gulp.task` usage. It is no longer the recommended way to define tasks, and it's behaviour has changed in a breaking way (no 3 argument task functions anymore). All task functions were refactored to `module.exports` functions e.g: `css` task -> `module.exports.css = function ...`
   
   Additionally, all task functions must now either return a stream, or use a callback function.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Ran `npm test` and varies of gulp tasks and the provided npm scripts.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-docs] erisu merged pull request #1101: Node12

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1101:
URL: https://github.com/apache/cordova-docs/pull/1101


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org