You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/04/18 00:01:02 UTC
[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
Hello Jean-Daniel Cryans, Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6659
to review the following change.
Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
......................................................................
KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
MiniCluster and ExternalMiniCluster utility classes follow opposite
semantics for restart. For eg, ExternalMiniCluster::Restart() expects
that all the nodes must be shutdown before we restart, whereas
MiniCluster::Restart() expects that all servers are up and running
so that it can internally execute shutdown and start in that order.
This patch changes the semantics of MiniCluster::Restart() to follow
that of ExternalMiniCluster::Restart() to keep them consistent and
the existing tests are modified to follow the new semantics of
MiniCluster::Restart().
Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Reviewed-on: http://gerrit.cloudera.org:8080/5598
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 4114ba9bf1cdfbd03eef2a13d6e51b6094527997)
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
M src/kudu/tserver/mini_tablet_server.cc
9 files changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/6659/1
--
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
......................................................................
Patch Set 1:
I was curious about the need for this patch. It's all test-side, which is great, but ideally we'd only be pulling bug fixes in dot dot releases. Thoughts?
--
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
......................................................................
Patch Set 1: Code-Review+1
LGTM
+1 since I suspect the gatekeepers of the 1.2 release are supposed to approve it with their +2
--
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
......................................................................
Patch Set 1: -Code-Review
> I was curious about the need for this patch. It's all test-side,
> which is great, but ideally we'd only be pulling bug fixes in dot
> dot releases. Thoughts?
As I understand, it's not necessary to merge this into the 1.2.x branch as it is. However, having this patch would allow to avoid editing MiniCluster::Restart()-related code if any new merged from the main trunk (e.g., a new test which exercises some particular scenario requiring restart of MiniCluster components).
--
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
......................................................................
Abandoned
I removed the need to backport this patch.
--
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart
......................................................................
Patch Set 1:
> As I understand, it's not necessary to merge this into the 1.2.x
> branch as it is. However, having this patch would allow to avoid
> editing MiniCluster::Restart()-related code if any new merged from
> the main trunk (e.g., a new test which exercises some particular
> scenario requiring restart of MiniCluster components).
Well so we have KUDU-1607 that depends on this, which we're trying to merge, but we need this patch to make it clean. But I was wondering if we could do without this.
--
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No