You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by "mike-mcgann (via GitHub)" <gi...@apache.org> on 2023/02/27 14:08:05 UTC

[GitHub] [daffodil] mike-mcgann commented on a diff in pull request #972: Update occursIndex to skip absent elements

mike-mcgann commented on code in PR #972:
URL: https://github.com/apache/daffodil/pull/972#discussion_r1118787393


##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/PState.scala:
##########
@@ -108,12 +113,16 @@ object MPState {
 class MPState private () {
 
   val arrayIndexStack = MStackOfLong()

Review Comment:
   It is kind of iterating over one array and creating a new array which may or may not be the same length. How about naming these two to be `arraySourcePos` and `arrayTargetPos`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org