[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1887: IGNITE-19105 Remove MetaStorage cursor management

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #1887:
URL: https://github.com/apache/ignite-3/pull/1887#discussion_r1159434366


##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/CursorSubscription.java:
##########
@@ -130,7 +126,9 @@ private void processRequest() {
                     demand--;
                 } else {
                     if (cachedResponse.hasNextBatch()) {
-                        requestNextBatch();
+                        byte[] lastProcessedKey = entries.get(entries.size() - 1).key();

Review Comment:
   I expect that if `cachedResponse#hasNextBatch` did returned `true`, then it is impossible to retrieve an empty response during the next data page (and the current response can't be empty either).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org