You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Marc Sherman <ms...@projectile.ca> on 2005/08/04 14:31:42 UTC
Re: [PATCH] svnperms.py: inherit settings from another section
Marc Sherman wrote:
>
> This is a patch against svn trunk to add section inheritance to the
> config parser in the snvperms.py hook script.
I posted this patch last week, and haven't gotten a reply yet. Is
svnperms.py no longer maintained?
The original patch is in the list archives at:
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=103489
I'd really appreciate any comnments, even if it's just "That script is
no longer maintained, and we're not accepting patches for it." Thanks,
- Marc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by Marc Sherman <ms...@projectile.ca>.
Gustavo Niemeyer wrote:
>
> The idea sounds interesting, but the syntax looks bizarre. I'd
> never guess from looking at the file that it does what Marc
> says it does.
Syntax is easy to modify, it's just a change to the regex.
> Perhaps naming the section like [parent/child], and making the
> section name be indeed "parent/child", rather than just "child",
> could be a better idea. This would make clear the "link" between
> these sections afterwards.
I'd be against that, because "parent/child" is currently a valid section
name in the existing syntax.
How about using a keyword to make the inheritance explicit? Such as:
[parentgroup]
...
[newgroup] extends [parentgroup]
...
> Here! I just reviewed my inbox and by spam mailbox. I don't have a
> message from you in any of them. I could have removed it when
> cleaning my inbox from spams, so I apologise if I did that.
>
> Can you please resend it?
It was just a pointer to the thread in the mailing list archive, and a
request for review, so there's no additional content you're missing.
The MessageId was <42...@projectile.ca>, sent on August 2, if
you'd like to track down what happened to the message in your MTA.
- Marc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by Gustavo Niemeyer <gu...@niemeyer.net>.
Hey Karl, Mark,
> >Well, first let me try CC'ing Gustavo Niemayer, the original author of
> >svnperms.py. It may be that he's not following the dev@subversion
> >list in detail these days, but he might have time to comment on this
> >patch.
The idea sounds interesting, but the syntax looks bizarre. I'd
never guess from looking at the file that it does what Marc
says it does.
Perhaps naming the section like [parent/child], and making the
section name be indeed "parent/child", rather than just "child",
could be a better idea. This would make clear the "link" between
these sections afterwards.
> I mailed Gustavo directly (off-list) on August 2, so my guess is that
> he's away from email currently.
Here! I just reviewed my inbox and by spam mailbox. I don't have a
message from you in any of them. I could have removed it when
cleaning my inbox from spams, so I apologise if I did that.
Can you please resend it?
--
Gustavo Niemeyer
http://niemeyer.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by Marc Sherman <ms...@projectile.ca>.
kfogel@collab.net wrote:
>
> Well, first let me try CC'ing Gustavo Niemayer, the original author of
> svnperms.py. It may be that he's not following the dev@subversion
> list in detail these days, but he might have time to comment on this
> patch.
I mailed Gustavo directly (off-list) on August 2, so my guess is that
he's away from email currently.
- Marc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by kf...@collab.net.
Marc Sherman <ms...@projectile.ca> writes:
> David James wrote:
> > Yup! As far as I can tell -- we'll have hook script experts on the
> > job soon :)
>
> Any progress on this front? Should I perhaps file an issue to make
> sure the patch doesn't get lost?
Well, first let me try CC'ing Gustavo Niemayer, the original author of
svnperms.py. It may be that he's not following the dev@subversion
list in detail these days, but he might have time to comment on this
patch.
Gustavo, see
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=103489
That post explains everything :-). If you like the patch, just commit
it; or if you don't have time to review it, let us know that too.
Thanks,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by Marc Sherman <ms...@projectile.ca>.
David James wrote:
>
> Yup! As far as I can tell -- we'll have hook script experts on the
> job soon :)
Any progress on this front? Should I perhaps file an issue to make sure
the patch doesn't get lost?
> If you have more ideas or patches, send them in. Your code is nicely
> organized, so it's a joy to review. We appreciate your work!
Thanks. Once someone more expert has a look at my first patch, and can
comment on my suggestion that the parallel maps and lists in the config
parser are redundant, I may take a stab at removing them myself, just to
simplify the script -- especially since that parser runs on every single
commit. Is there interest in me doing this? I'd like to get my python
skills a bit sharper, so maybe I can look at the performance problems in
contrib/hook-scripts/check-case-insensitive.py next.
- Marc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by David James <ja...@gmail.com>.
On 8/5/05, Marc Sherman <ms...@projectile.ca> wrote:
> Sure, changing the syntax should be simple. Let me know if you have any
> ideas for a syntax you like better. The code that actually implements
> the inheritance looks ok, though?
Yup! As far as I can tell -- we'll have hook script experts on the job soon :)
If you have more ideas or patches, send them in. Your code is nicely
organized, so it's a joy to review. We appreciate your work!
Best,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by Marc Sherman <ms...@projectile.ca>.
David James wrote:
>
> Nice patch, Marc! Your code looks good. I think we can probably come
> up with a more clear syntax for expressing section inheritence,
> though. As far as I can tell, your patch has already implemented
> everything we need, code-wise. Do you mind if we think about this for
> a bit longer? I'd like to hear what the other committers have to say
> on this.
Sure, changing the syntax should be simple. Let me know if you have any
ideas for a syntax you like better. The code that actually implements
the inheritance looks ok, though? I've tested it in my test repo, but I
was anxious about checking it into my live repo before someone here had
a look at it. Thanks,
- Marc
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svnperms.py: inherit settings from another section
Posted by David James <ja...@gmail.com>.
On 8/4/05, Marc Sherman <ms...@projectile.ca> wrote:
> Marc Sherman wrote:
> >
> > This is a patch against svn trunk to add section inheritance to the
> > config parser in the snvperms.py hook script.
> I posted this patch last week, and haven't gotten a reply yet. Is
> svnperms.py no longer maintained?
Nice patch, Marc! Your code looks good. I think we can probably come
up with a more clear syntax for expressing section inheritence,
though. As far as I can tell, your patch has already implemented
everything we need, code-wise. Do you mind if we think about this for
a bit longer? I'd like to hear what the other committers have to say
on this.
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org