You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/30 03:00:01 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3209: ARTEMIS-2797 Fixing user update Null
clebertsuconic opened a new pull request #3209:
URL: https://github.com/apache/activemq-artemis/pull/3209
UpdateQueueTest::testUpdateQueueWithFilter was broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3209: ARTEMIS-2797 Fixing user update Null
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3209:
URL: https://github.com/apache/activemq-artemis/pull/3209#issuecomment-652154808
@michaelandrepearce I will run some more tests . I added another commit here trying to fix another issue with redeployment on the divert.
I want to run more tests before merging this... (I lost my window for the release anyways.. it's 4th July weekend and I have some personal time off as well).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3209: ARTEMIS-2797 Fixing user update Null
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3209:
URL: https://github.com/apache/activemq-artemis/pull/3209#issuecomment-651495563
@jbertram can you please review this?
there was a test broken after #3201
The definition of your test seems to clash with #3201 ... so I need your review here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3209: ARTEMIS-2797 Fixing user update Null
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3209:
URL: https://github.com/apache/activemq-artemis/pull/3209#issuecomment-652080425
@clebertsuconic merge this. Can be fixed separately if there is need to remove a user in update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3209: ARTEMIS-2797 Fixing user update Null
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3209:
URL: https://github.com/apache/activemq-artemis/pull/3209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org