[GitHub] [incubator-superset] nytai commented on a change in pull request #10380: fix(datasets): sort and humanized modified by

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10380:
URL: https://github.com/apache/incubator-superset/pull/10380#discussion_r458268204



##########
File path: superset-frontend/src/views/datasetList/DatasetList.tsx
##########
@@ -277,31 +275,16 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
     {
       Header: t('Schema'),
       accessor: 'schema',
-      disableSortBy: true,
       size: 'lg',
     },
     {
       Cell: ({
         row: {
-          original: { changed_on: changedOn },
+          original: { changed_on_delta_humanized: changedOn },
         },
-      }: any) => {
-        const momentTime = moment(changedOn);
-        const time = momentTime.format(SHORT_DATE);
-        const date = momentTime.format(SHORT_TIME);
-        return (
-          <TooltipWrapper
-            label="last-modified"
-            tooltip={time}
-            placement="right"
-          >
-            <span>{date}</span>
-          </TooltipWrapper>
-        );
-      },
-      Header: t('Last Modified'),
-      accessor: 'changed_on',
-      size: 'xl',
+      }: any) => <span className="no-wrap">{changedOn}</span>,
+      Header: t('Modified'),
+      accessor: 'changed_on_delta_humanized',

Review comment:
       can you add back the `size: 'xl'` property which should ensure even spacing between columns




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org