You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/27 05:45:56 UTC
[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #145: Use
DEFAULT_TASK_STACKSIZE
yamt opened a new pull request #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on issue
#145: Use DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604835939
> using more memory might or might not be safe for small systems.
> for examples and testing, it might be fine though.
Yes, but:
1.The memory for each application increase is no more than 1.5K
2.We most likely don't run all this application at the same time
3.These application normally is launched by user manually
So the suggestion in most case:
1.Don't increase the memory consumption after boot finish
2.Just increase 1.5KB when user launch these application
But on the other hand:
1.Unify the whole code base
2.Make these applications can run on sim
So I think it's good thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #145: Use
DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604835939
> using more memory might or might not be safe for small systems.
> for examples and testing, it might be fine though.
Yes, but:
1.The memory for each application increase is no more than 1.5K
2.We most likely don't run all this application at the same time
3.These application normally is launched by user manually
So the suggestion in most case:
1.Don't increase the memory consumption after boot finish
2.Just increase 1.5KB when user launch these application
But:
1.Unify the whole code base
2.Make this application can run on sim
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt commented on issue #145: Use
DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604839105
@xiaoxiang781216 ok. done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on issue
#145: Use DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604835939
> using more memory might or might not be safe for small systems.
> for examples and testing, it might be fine though.
Yes, but since:
1.The memory for each application increase is no more than 1.5K
2.We most likely don't run all this application at the same time
3.These application normally is launched by user manually
The suggestion in most case:
1.Don't increase the memory consumption after boot finish
2.Just increase 1.5KB when user launch these application
On the other hand:
1.Unify the whole code base
2.Make these applications can run on sim
So it's a good comprimise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #145:
Use DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #145: Use
DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604843188
> @xiaoxiang781216 ok. done
Should we change SYSTEM_RAMTEST_STACKSIZE too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt commented on issue #145: Use
DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604833820
using more memory might or might not be safe for small systems.
for examples and testing, it might be fine though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] yamt commented on issue #145: Use
DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604852088
i guess stack size is not too important for what ramtest does. done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on issue
#145: Use DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604835939
> using more memory might or might not be safe for small systems.
> for examples and testing, it might be fine though.
Yes, but:
1.The memory for each application increase is no more than 1.5K
2.We most likely don't run all this application at the same time
3.These application normally is launched by user manually
So the suggestion in most case:
1.Don't increase the memory consumption after boot finish
2.Just increase 1.5KB when user launch these application
But:
1.Unify the whole code base
2.Make these applications can run on sim
So I think it's good thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on issue
#145: Use DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604831639
Nice patch!
How about we change the default stack size which is smaller than 2048 to DEFAULT_STACK_SIZE, but keep other big stack size as before:
examples/igmp/Makefile:STACKSIZE = 1024
examples/powerled/Makefile:STACKSIZE = 1024
examples/powermonitor/Makefile:STACKSIZE = 768
examples/relays/Makefile:STACKSIZE = 512
examples/smps/Makefile:STACKSIZE = 1024
graphics/screenshot/Makefile:STACKSIZE = 4096
system/flash_eraseall/Makefile:STACKSIZE = 1024
testing/cxxtest/Makefile:STACKSIZE = 4096
testing/smart_test/Makefile:STACKSIZE = 4096
Since the change is safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #145: Use
DEFAULT_TASK_STACKSIZE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #145: Use DEFAULT_TASK_STACKSIZE
URL: https://github.com/apache/incubator-nuttx-apps/pull/145#issuecomment-604831639
Nice patch! how about we change the default stack size which small than 2048 to DEFAULT_STACK_SIZE, but keep other big stack size as it:
examples/igmp/Makefile:STACKSIZE = 1024
examples/powerled/Makefile:STACKSIZE = 1024
examples/powermonitor/Makefile:STACKSIZE = 768
examples/relays/Makefile:STACKSIZE = 512
examples/smps/Makefile:STACKSIZE = 1024
graphics/screenshot/Makefile:STACKSIZE = 4096
system/flash_eraseall/Makefile:STACKSIZE = 1024
testing/cxxtest/Makefile:STACKSIZE = 4096
testing/smart_test/Makefile:STACKSIZE = 4096
Since the change is safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services