You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org> on 2009/07/08 21:03:14 UTC
[jira] Created: (TRINIDAD-1530) The onsubmit function of tr:form is
called after a client side validation error occurs and the form is not
submitted.
The onsubmit function of tr:form is called after a client side validation error occurs and the form is not submitted.
---------------------------------------------------------------------------------------------------------------------
Key: TRINIDAD-1530
URL: https://issues.apache.org/jira/browse/TRINIDAD-1530
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 1.2.11-core
Reporter: Bernd Bohmann
Documentation of the onsubmit attribute of tr:form:
Javascript code to be called when the form is submitted.
I don't expect that this code is called if a client side validation error occurs and the form is not submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1530) The onsubmit function of tr:form is
called after a client side validation error occurs and the form is not
submitted.
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated TRINIDAD-1530:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.10-plugins
Assignee: Matthias Weßendorf
Status: Resolved (was: Patch Available)
> The onsubmit function of tr:form is called after a client side validation error occurs and the form is not submitted.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1530
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1530
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.11-core
> Reporter: Bernd Bohmann
> Assignee: Matthias Weßendorf
> Fix For: 1.2.10-plugins
>
> Attachments: TRINIDAD-1530.patch
>
>
> Documentation of the onsubmit attribute of tr:form:
> Javascript code to be called when the form is submitted.
> I don't expect that this code is called if a client side validation error occurs and the form is not submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1530) The onsubmit function of tr:form
is called after a client side validation error occurs and the form is not
submitted.
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729386#action_12729386 ]
Bernd Bohmann commented on TRINIDAD-1530:
-----------------------------------------
This patch implements the expected behavior.
But if someone has used the onsubmit function for own client side validation. The function is only called if no client side validation error from trinidad occurs.
> The onsubmit function of tr:form is called after a client side validation error occurs and the form is not submitted.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1530
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1530
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.11-core
> Reporter: Bernd Bohmann
> Attachments: TRINIDAD-1530.patch
>
>
> Documentation of the onsubmit attribute of tr:form:
> Javascript code to be called when the form is submitted.
> I don't expect that this code is called if a client side validation error occurs and the form is not submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1530) The onsubmit function of tr:form is
called after a client side validation error occurs and the form is not
submitted.
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bernd Bohmann updated TRINIDAD-1530:
------------------------------------
Status: Patch Available (was: Open)
> The onsubmit function of tr:form is called after a client side validation error occurs and the form is not submitted.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1530
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1530
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.11-core
> Reporter: Bernd Bohmann
> Attachments: TRINIDAD-1530.patch
>
>
> Documentation of the onsubmit attribute of tr:form:
> Javascript code to be called when the form is submitted.
> I don't expect that this code is called if a client side validation error occurs and the form is not submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (TRINIDAD-1530) The onsubmit function of
tr:form is called after a client side validation error occurs and the form is
not submitted.
Posted by Bernd Bohmann <be...@atanion.com>.
I think it is undefined.
should i use
onSubmit !== undefined
or
typeof onSubmit != "undefined"
Thanks
Bernd
On Thu, Jul 9, 2009 at 6:32 PM, Blake Sullivan<bl...@oracle.com> wrote:
> The direct replacement for the void operator is "undefined". Does he really
> want undefined or does he want null.
>
> -- Blake
>
> Matthias Weßendorf (JIRA) said the following On 7/9/2009 5:59 AM PT:
>
> [
> https://issues.apache.org/jira/browse/TRINIDAD-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729242#action_12729242
> ]
>
> Matthias Weßendorf commented on TRINIDAD-1530:
> ----------------------------------------------
>
> sounds right. The value of the "doSubmit" is already false at the point
> where we check for the custom onsubmit handler;
>
> Calling the handler regardless sounds like a bug to me.
>
> Oh, can you replace the outdated (void 0) with null ?
> (in case you are willing to provide a patch)
>
>
>
> The onsubmit function of tr:form is called after a client side validation
> error occurs and the form is not submitted.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1530
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1530
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.11-core
> Reporter: Bernd Bohmann
>
> Documentation of the onsubmit attribute of tr:form:
> Javascript code to be called when the form is submitted.
> I don't expect that this code is called if a client side validation error
> occurs and the form is not submitted.
>
>
>
>
Re: [jira] Commented: (TRINIDAD-1530) The onsubmit function of tr:form
is called after a client side validation error occurs and the form is not
submitted.
Posted by Blake Sullivan <bl...@oracle.com>.
The direct replacement for the void operator is "undefined". Does he
really want undefined or does he want null.
-- Blake
Matthias Weßendorf (JIRA) said the following On 7/9/2009 5:59 AM PT:
> [ https://issues.apache.org/jira/browse/TRINIDAD-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729242#action_12729242 ]
>
> Matthias Weßendorf commented on TRINIDAD-1530:
> ----------------------------------------------
>
> sounds right. The value of the "doSubmit" is already false at the point where we check for the custom onsubmit handler;
>
> Calling the handler regardless sounds like a bug to me.
>
> Oh, can you replace the outdated (void 0) with null ?
> (in case you are willing to provide a patch)
>
>
>> The onsubmit function of tr:form is called after a client side validation error occurs and the form is not submitted.
>> ---------------------------------------------------------------------------------------------------------------------
>>
>> Key: TRINIDAD-1530
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-1530
>> Project: MyFaces Trinidad
>> Issue Type: Bug
>> Affects Versions: 1.2.11-core
>> Reporter: Bernd Bohmann
>>
>> Documentation of the onsubmit attribute of tr:form:
>> Javascript code to be called when the form is submitted.
>> I don't expect that this code is called if a client side validation error occurs and the form is not submitted.
>>
>
>
[jira] Commented: (TRINIDAD-1530) The onsubmit function of tr:form
is called after a client side validation error occurs and the form is not
submitted.
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729242#action_12729242 ]
Matthias Weßendorf commented on TRINIDAD-1530:
----------------------------------------------
sounds right. The value of the "doSubmit" is already false at the point where we check for the custom onsubmit handler;
Calling the handler regardless sounds like a bug to me.
Oh, can you replace the outdated (void 0) with null ?
(in case you are willing to provide a patch)
> The onsubmit function of tr:form is called after a client side validation error occurs and the form is not submitted.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1530
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1530
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.11-core
> Reporter: Bernd Bohmann
>
> Documentation of the onsubmit attribute of tr:form:
> Javascript code to be called when the form is submitted.
> I don't expect that this code is called if a client side validation error occurs and the form is not submitted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.