You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Alexandro Colorado <jz...@oooes.org> on 2013/09/13 22:15:06 UTC
[BUG] XSL Stylesheet markup on CSS from Wizard
Please implement the following patch from bug 95765. I have tested the bug
and seem that we only need to patch the stylesheet so that the CSS get's
correctly mapped.
from:
<span *class=*"doclastchangedate">
t
o:
<span *class=*"doclastchange
d
date">
Please apply.
File currently lives at:
http://svn.apache.org/viewvc/openoffice/trunk/main/extras/source/misc_config/wizard/web/layouts/
--
Alexandro Colorado
Apache OpenOffice Contributor
http://www.openoffice.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by daf safaa <da...@gmail.com>.
Hi
I can verify the same issue under those files it misses an extra "d" on the
both of them 'layout.xsl' and 'layoutX.xsl'.
Regards
2013/9/17 Alexandro Colorado <jz...@oooes.org>
> I update the XSLT directly on the binary. Both stylesheets are ascii so you
> can verify them here:
> $[openoffice_home]/share/config/wizard/web/layouts/layoutX.xsl and
> layout.xsl
>
>
> On Tue, Sep 17, 2013 at 5:04 PM, Andrea Pescetti <pescetti@apache.org
> >wrote:
>
> > (follow-up to dev, please)
> >
> >
> > On 16/09/2013 Alexandro Colorado wrote:
> >
> >> Any update on this? This fix seems simple enough to promote the patch.
> >>
> >
> > The fix is indeed minimal, but let's make sure it is properly tested. How
> > did you test it?
> >
> > Did you build OpenOffice with the patch applied and tried the Web Page
> > wizard? (This might sound overkill for a patch that simply corrects a CSS
> > class name, but it doesn't harm and if you wish I can make this check for
> > you, just ask).
> >
> > Or did you apply the patch (and which one? the first one, the second one
> > or both?) to an installed OpenOffice and tried with the Web Page Wizard?
> >
> > References:
> > https://issues.apache.org/ooo/**show_bug.cgi?id=95765<
> https://issues.apache.org/ooo/show_bug.cgi?id=95765>Bug description
> > https://issues.apache.org/ooo/**attachment.cgi?id=57656<
> https://issues.apache.org/ooo/attachment.cgi?id=57656>First patch
> > https://issues.apache.org/ooo/**attachment.cgi?id=57657<
> https://issues.apache.org/ooo/attachment.cgi?id=57657>Second patch
> >
> >
> > I tried doing the commit but get an repo error:
> >> svn: Commit failed (details follow):
> >>
> >
> > We will have to check this too. But let's get the patch tested, then move
> > to this.
> >
> > Regards,
> > Andrea.
> >
> > ------------------------------**------------------------------**---------
> > To unsubscribe, e-mail: qa-unsubscribe@openoffice.**apache.org<
> qa-unsubscribe@openoffice.apache.org>
> > For additional commands, e-mail: qa-help@openoffice.apache.org
> >
> >
>
>
> --
> Alexandro Colorado
> Apache OpenOffice Contributor
> http://www.openoffice.org
>
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Andrea Pescetti <pe...@apache.org>.
On 18/09/2013 Alexandro Colorado wrote:
> I update the XSLT directly on the binary. Both stylesheets are ascii so you
> can verify them here:
> $[openoffice_home]/share/config/wizard/web/layouts/layoutX.xsl and
> layout.xsl
Patch now committed (patched trunk, rebuilt OpenOffice, verified). It
took a while, thanks for your patience. See
https://issues.apache.org/ooo/show_bug.cgi?id=95765
for details.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Andrea Pescetti <pe...@apache.org>.
On 18/09/2013 Alexandro Colorado wrote:
> I update the XSLT directly on the binary. Both stylesheets are ascii so you
> can verify them here:
> $[openoffice_home]/share/config/wizard/web/layouts/layoutX.xsl and
> layout.xsl
Patch now committed (patched trunk, rebuilt OpenOffice, verified). It
took a while, thanks for your patience. See
https://issues.apache.org/ooo/show_bug.cgi?id=95765
for details.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Alexandro Colorado <jz...@oooes.org>.
I update the XSLT directly on the binary. Both stylesheets are ascii so you
can verify them here:
$[openoffice_home]/share/config/wizard/web/layouts/layoutX.xsl and
layout.xsl
On Tue, Sep 17, 2013 at 5:04 PM, Andrea Pescetti <pe...@apache.org>wrote:
> (follow-up to dev, please)
>
>
> On 16/09/2013 Alexandro Colorado wrote:
>
>> Any update on this? This fix seems simple enough to promote the patch.
>>
>
> The fix is indeed minimal, but let's make sure it is properly tested. How
> did you test it?
>
> Did you build OpenOffice with the patch applied and tried the Web Page
> wizard? (This might sound overkill for a patch that simply corrects a CSS
> class name, but it doesn't harm and if you wish I can make this check for
> you, just ask).
>
> Or did you apply the patch (and which one? the first one, the second one
> or both?) to an installed OpenOffice and tried with the Web Page Wizard?
>
> References:
> https://issues.apache.org/ooo/**show_bug.cgi?id=95765<https://issues.apache.org/ooo/show_bug.cgi?id=95765>Bug description
> https://issues.apache.org/ooo/**attachment.cgi?id=57656<https://issues.apache.org/ooo/attachment.cgi?id=57656>First patch
> https://issues.apache.org/ooo/**attachment.cgi?id=57657<https://issues.apache.org/ooo/attachment.cgi?id=57657>Second patch
>
>
> I tried doing the commit but get an repo error:
>> svn: Commit failed (details follow):
>>
>
> We will have to check this too. But let's get the patch tested, then move
> to this.
>
> Regards,
> Andrea.
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: qa-unsubscribe@openoffice.**apache.org<qa...@openoffice.apache.org>
> For additional commands, e-mail: qa-help@openoffice.apache.org
>
>
--
Alexandro Colorado
Apache OpenOffice Contributor
http://www.openoffice.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Alexandro Colorado <jz...@oooes.org>.
I update the XSLT directly on the binary. Both stylesheets are ascii so you
can verify them here:
$[openoffice_home]/share/config/wizard/web/layouts/layoutX.xsl and
layout.xsl
On Tue, Sep 17, 2013 at 5:04 PM, Andrea Pescetti <pe...@apache.org>wrote:
> (follow-up to dev, please)
>
>
> On 16/09/2013 Alexandro Colorado wrote:
>
>> Any update on this? This fix seems simple enough to promote the patch.
>>
>
> The fix is indeed minimal, but let's make sure it is properly tested. How
> did you test it?
>
> Did you build OpenOffice with the patch applied and tried the Web Page
> wizard? (This might sound overkill for a patch that simply corrects a CSS
> class name, but it doesn't harm and if you wish I can make this check for
> you, just ask).
>
> Or did you apply the patch (and which one? the first one, the second one
> or both?) to an installed OpenOffice and tried with the Web Page Wizard?
>
> References:
> https://issues.apache.org/ooo/**show_bug.cgi?id=95765<https://issues.apache.org/ooo/show_bug.cgi?id=95765>Bug description
> https://issues.apache.org/ooo/**attachment.cgi?id=57656<https://issues.apache.org/ooo/attachment.cgi?id=57656>First patch
> https://issues.apache.org/ooo/**attachment.cgi?id=57657<https://issues.apache.org/ooo/attachment.cgi?id=57657>Second patch
>
>
> I tried doing the commit but get an repo error:
>> svn: Commit failed (details follow):
>>
>
> We will have to check this too. But let's get the patch tested, then move
> to this.
>
> Regards,
> Andrea.
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: qa-unsubscribe@openoffice.**apache.org<qa...@openoffice.apache.org>
> For additional commands, e-mail: qa-help@openoffice.apache.org
>
>
--
Alexandro Colorado
Apache OpenOffice Contributor
http://www.openoffice.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Andrea Pescetti <pe...@apache.org>.
(follow-up to dev, please)
On 16/09/2013 Alexandro Colorado wrote:
> Any update on this? This fix seems simple enough to promote the patch.
The fix is indeed minimal, but let's make sure it is properly tested.
How did you test it?
Did you build OpenOffice with the patch applied and tried the Web Page
wizard? (This might sound overkill for a patch that simply corrects a
CSS class name, but it doesn't harm and if you wish I can make this
check for you, just ask).
Or did you apply the patch (and which one? the first one, the second one
or both?) to an installed OpenOffice and tried with the Web Page Wizard?
References:
https://issues.apache.org/ooo/show_bug.cgi?id=95765 Bug description
https://issues.apache.org/ooo/attachment.cgi?id=57656 First patch
https://issues.apache.org/ooo/attachment.cgi?id=57657 Second patch
> I tried doing the commit but get an repo error:
> svn: Commit failed (details follow):
We will have to check this too. But let's get the patch tested, then
move to this.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Andrea Pescetti <pe...@apache.org>.
(follow-up to dev, please)
On 16/09/2013 Alexandro Colorado wrote:
> Any update on this? This fix seems simple enough to promote the patch.
The fix is indeed minimal, but let's make sure it is properly tested.
How did you test it?
Did you build OpenOffice with the patch applied and tried the Web Page
wizard? (This might sound overkill for a patch that simply corrects a
CSS class name, but it doesn't harm and if you wish I can make this
check for you, just ask).
Or did you apply the patch (and which one? the first one, the second one
or both?) to an installed OpenOffice and tried with the Web Page Wizard?
References:
https://issues.apache.org/ooo/show_bug.cgi?id=95765 Bug description
https://issues.apache.org/ooo/attachment.cgi?id=57656 First patch
https://issues.apache.org/ooo/attachment.cgi?id=57657 Second patch
> I tried doing the commit but get an repo error:
> svn: Commit failed (details follow):
We will have to check this too. But let's get the patch tested, then
move to this.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Alexandro Colorado <jz...@oooes.org>.
Any update on this? This fix seems simple enough to promote the patch.
I tried doing the commit but get an repo error:
svn: Commit failed (details follow):
svn: access to '/repos/asf/!svn/act/fa79bdb8-1d7f-45dc-8372-0f09658a7180'
forbidden
On 9/13/13, Alexandro Colorado <jz...@oooes.org> wrote:
> Please implement the following patch from bug 95765. I have tested the bug
> and seem that we only need to patch the stylesheet so that the CSS get's
> correctly mapped.
>
> from:
>
> <span *class=*"doclastchangedate">
>
> t
> o:
>
> <span *class=*"doclastchange
> d
> date">
>
> Please apply.
> File currently lives at:
> http://svn.apache.org/viewvc/openoffice/trunk/main/extras/source/misc_config/wizard/web/layouts/
>
> --
> Alexandro Colorado
> Apache OpenOffice Contributor
> http://www.openoffice.org
>
--
Alexandro Colorado
Apache OpenOffice Contributor
http://www.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by "Marco A.G.Pinto" <ma...@mail.telepac.pt>.
On 13/09/2013 21:15, Alexandro Colorado wrote:
> Please implement the following patch from bug 95765. I have tested the bug
> and seem that we only need to patch the stylesheet so that the CSS get's
> correctly mapped.
>
> from:
>
> <span *class=*"doclastchangedate">
>
> t
> o:
>
> <span *class=*"doclastchange
> d
> date">
>
> Please apply.
> File currently lives at:
> http://svn.apache.org/viewvc/openoffice/trunk/main/extras/source/misc_config/wizard/web/layouts/
>
It seems:
<xsl:template match="document/@update-date">
<span class="doclastchangedate">
<xsl:value-of select="."/>
</span>
<br/>
</xsl:template>
There is a missing "d" in the changedate, like Alexandro told me to look
for.
Kind regards,
>Marco A.G.Pinto
------------------------
--
Re: [BUG] XSL Stylesheet markup on CSS from Wizard
Posted by Alexandro Colorado <jz...@oooes.org>.
Any update on this? This fix seems simple enough to promote the patch.
I tried doing the commit but get an repo error:
svn: Commit failed (details follow):
svn: access to '/repos/asf/!svn/act/fa79bdb8-1d7f-45dc-8372-0f09658a7180'
forbidden
On 9/13/13, Alexandro Colorado <jz...@oooes.org> wrote:
> Please implement the following patch from bug 95765. I have tested the bug
> and seem that we only need to patch the stylesheet so that the CSS get's
> correctly mapped.
>
> from:
>
> <span *class=*"doclastchangedate">
>
> t
> o:
>
> <span *class=*"doclastchange
> d
> date">
>
> Please apply.
> File currently lives at:
> http://svn.apache.org/viewvc/openoffice/trunk/main/extras/source/misc_config/wizard/web/layouts/
>
> --
> Alexandro Colorado
> Apache OpenOffice Contributor
> http://www.openoffice.org
>
--
Alexandro Colorado
Apache OpenOffice Contributor
http://www.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org