You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by a1singh <gi...@git.apache.org> on 2015/11/04 02:26:50 UTC
[GitHub] spark pull request: Update LDAOptimizer.scala
GitHub user a1singh opened a pull request:
https://github.com/apache/spark/pull/9456
Update LDAOptimizer.scala
In file LDAOptimizer.scala:
line 441: since "idx" was never used, replaced unrequired zipWithIndex.foreach with foreach.
- nonEmptyDocs.zipWithIndex.foreach { case ((_, termCounts: Vector), idx: Int) =>
+ nonEmptyDocs.foreach { case (_, termCounts: Vector) =>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/a1singh/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9456
----
commit ba0879bb8d9949146ca72401d195fcfb04edc3ba
Author: a1singh <a1...@ucsd.edu>
Date: 2015-11-04T01:22:33Z
Update LDAOptimizer.scala
line 441: since idx was never used, replaced unrequired zipWithIndex.foreach with foreach
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update LDAOptimizer.scala
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-153671919
@a1singh looks trivial, but OK. This isn't quite how you propose changes; this isn't a descriptive title for example. Please read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
Please also see if you can find other instances of the same problem that can be optimized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11506][MLLIB]: Removed redundant operat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-154003232
**[Test build #1987 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1987/consoleFull)** for PR 9456 at commit [`ba0879b`](https://github.com/apache/spark/commit/ba0879bb8d9949146ca72401d195fcfb04edc3ba).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update LDAOptimizer.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-153541597
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11506][MLLIB]: Removed redundant operat...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-154050274
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11506][MLLIB]: Removed redundant operat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-154042495
**[Test build #1987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1987/consoleFull)** for PR 9456 at commit [`ba0879b`](https://github.com/apache/spark/commit/ba0879bb8d9949146ca72401d195fcfb04edc3ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11506][MLLIB]: Removed redundant operat...
Posted by a1singh <gi...@git.apache.org>.
Github user a1singh commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-154132817
Thanks @srowen @hvanhovell
I would be glad to help with other activities.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11506][MLLIB]: Removed redundant operat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11506][MLLIB]: Removed redundant operat...
Posted by a1singh <gi...@git.apache.org>.
Github user a1singh commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-153913574
@hvanhovell started a JIRA request and added the number to the title of this PR. In future, other similar micro-changes in MLLIB can be linked to this JIRA.
@srowen thanks for the link. I checked other files under Clustering, and they seem to be fine, with respect to this optimization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Update LDAOptimizer.scala
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9456#issuecomment-153630052
Could you add the number of the JIRA ticket this relates to? See other PRs for an example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org