[jira] [Commented] (HBASE-7862) Support concurrent snapshots (on different tables)

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601812#comment-13601812 ] 

Ted Yu commented on HBASE-7862:
-------------------------------

In SnapshotManager:
{code}
+  // TODO - enable having multiple snapshots with multiple monitors/threads
+  // this needs to be configuration based when running multiple snapshots is implemented
+  /** number of current operations running on the master */
+  private static final int opThreads = 1;
...
+  synchronized boolean isTakingSnapshot() throws SnapshotCreationException {
+    // TODO later when we handle multiple there would be a map with ssname to handler.
+    return handler != null && !handler.isFinished();
{code}
In RegionServerSnapshotManager:
{code}
+     * Submit a task to the pool.
+     *
+     * NOTE: all must be submitted before you can safely {@link #waitForOutstandingTasks()}. This
+     * version does not support issuing tasks from multiple concurrent table snapshots requests.
+     */
+    void submitTask(final Callable<Void> task) {
{code}
                
> Support concurrent snapshots (on different tables)
> --------------------------------------------------
>
>                 Key: HBASE-7862
>                 URL: https://issues.apache.org/jira/browse/HBASE-7862
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>
> From SnapshotManager:
> {code}
>  * Note: Currently there can only be one snapshot being taken at a time over the cluster. This is a
>  * simplification in the current implementation.
> {code}
> We should support concurrent snapshots (on different tables)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira