[jira] [Work logged] (GOBBLIN-806) Enable metrics reporter during dataset discovery for retention job

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-806?focusedWorklogId=261895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261895 ]

ASF GitHub Bot logged work on GOBBLIN-806:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jun/19 23:11
            Start Date: 17/Jun/19 23:11
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 commented on pull request #2672: [GOBBLIN-806]Enable metrics reporter during dataset discovery for retention job
URL: https://github.com/apache/incubator-gobblin/pull/2672
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-806
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
    1. Change datasetCleaner to pass the eventSubmitter to dataset finder
    2. Change MultiDatasetFinder to enable datasetFinder with/without EventSubmitter
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Test on faro for both ConfigBasedCleanabledDatasetFinder and TMSBasedCleanableDatasetsFinder for retention job.
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 261895)
            Time Spent: 10m
    Remaining Estimate: 0h

> Enable metrics reporter during dataset discovery for retention job
> ------------------------------------------------------------------
>
>                 Key: GOBBLIN-806
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-806
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)