You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2017/01/31 05:36:37 UTC
Review Request 56112: Attempt to load module before checking if
overlayfs is supported.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56112/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Zhitao Li.
Bugs: MESOS-7034
https://issues.apache.org/jira/browse/MESOS-7034
Repository: mesos
Description
-------
Since overlayfs is optional on most kernels, it may not be loaded
by default. Hence attempt to run a modprobe command to load the
module before checking /proc/filesystems to verify that overlayfs
is supported by the running kernel.
Diffs
-----
src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b
Diff: https://reviews.apache.org/r/56112/diff/
Testing
-------
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 56112: Attempt to load module before checking if
overlayfs is supported.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56112/#review163635
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56112]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 31, 2017, 5:36 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56112/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 5:36 a.m.)
>
>
> Review request for mesos, Jie Yu and Zhitao Li.
>
>
> Bugs: MESOS-7034
> https://issues.apache.org/jira/browse/MESOS-7034
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since overlayfs is optional on most kernels, it may not be loaded
> by default. Hence attempt to run a modprobe command to load the
> module before checking /proc/filesystems to verify that overlayfs
> is supported by the running kernel.
>
>
> Diffs
> -----
>
> src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b
>
> Diff: https://reviews.apache.org/r/56112/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>