[GitHub] [lucene] iverase commented on a change in pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

[GitBox <gi...@apache.org>]

iverase commented on a change in pull request #692:
URL: https://github.com/apache/lucene/pull/692#discussion_r809966771



##########
File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
##########
@@ -167,99 +85,44 @@ public void add(DocIdSetIterator iter) throws IOException {
       return;
     }

Review comment:
       I haven't change the implementation here but this looks buggy for me. If the bitSet is not null we don't update counter any more in this case? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org