You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2015/05/06 10:42:29 UTC
svn commit: r1677950 -
/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
Author: centic
Date: Wed May 6 08:42:28 2015
New Revision: 1677950
URL: http://svn.apache.org/r1677950
Log:
Try to fix flaky test by waiting for a switch of the second to ensure that we have the same timestamps in the two workbooks that we compare byte-wise in this test.
Modified:
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java?rev=1677950&r1=1677949&r2=1677950&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java Wed May 6 08:42:28 2015
@@ -1561,6 +1561,15 @@ public final class TestXSSFBugs extends
cell.setCellValue("Hi");
sheet.setRepeatingRows(new CellRangeAddress(0, 0, 0, 0));
+ // small hack to try to make this test stable, previously it failed whenever the two written ZIP files had different file-creation
+ // dates stored.
+ // We try to do a loop until the current second changes in order to avoid problems with some date information that is written to the ZIP and thus
+ // causes differences
+ long start = System.currentTimeMillis()/1000;
+ while(System.currentTimeMillis()/1000 == start) {
+ Thread.sleep(10);
+ }
+
ByteArrayOutputStream bos = new ByteArrayOutputStream(8096);
wb.write(bos);
byte firstSave[] = bos.toByteArray();
@@ -1568,6 +1577,13 @@ public final class TestXSSFBugs extends
wb.write(bos);
byte secondSave[] = bos.toByteArray();
+ /*OutputStream stream = new FileOutputStream("C:\\temp\\poi.xlsx");
+ try {
+ wb.write(stream);
+ } finally {
+ stream.close();
+ }*/
+
assertArrayEquals("Had: \n" + Arrays.toString(firstSave) + " and \n" + Arrays.toString(secondSave),
firstSave, secondSave);
@@ -2439,7 +2455,7 @@ public final class TestXSSFBugs extends
wb.close();
}
-
+
/**
* .xlsx supports 64000 cell styles, the style indexes after
* 32,767 must not be -32,768, then -32,767, -32,766
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org