You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "ev1lQuark (via GitHub)" <gi...@apache.org> on 2024/01/09 06:07:27 UTC
[PR] feat: impl cache bootstrap [dubbo-kubernetes]
ev1lQuark opened a new pull request, #138:
URL: https://github.com/apache/dubbo-kubernetes/pull/138
## What is the purpose of the change
Add cache configuration reading and initialization process.
## How to verify this change
XXXX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: impl cache bootstrap [dubbo-kubernetes]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #138:
URL: https://github.com/apache/dubbo-kubernetes/pull/138#discussion_r1446839026
##########
pkg/admin/bootstrap.go:
##########
@@ -103,7 +103,7 @@ func RegisterOther(rt core_runtime.Runtime) error {
if err != nil {
panic(err)
}
- config.AdminRegistry, err = registry.Registry(c.GetProtocol(), addrUrl) // TODO: support k8s
+ config.AdminRegistry, config.Cache, err = registry.Registry(c.GetProtocol(), addrUrl, rt.KubeClient())
Review Comment:
Here, it returns both `config.AdminRegistry` and `config.Cache`, is `config.AdminRegistry` still necessary? what do we need it for later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: impl cache bootstrap [dubbo-kubernetes]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #138:
URL: https://github.com/apache/dubbo-kubernetes/pull/138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: impl cache bootstrap [dubbo-kubernetes]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #138:
URL: https://github.com/apache/dubbo-kubernetes/pull/138#discussion_r1446946943
##########
pkg/admin/bootstrap.go:
##########
@@ -103,7 +103,7 @@ func RegisterOther(rt core_runtime.Runtime) error {
if err != nil {
panic(err)
}
- config.AdminRegistry, err = registry.Registry(c.GetProtocol(), addrUrl) // TODO: support k8s
+ config.AdminRegistry, config.Cache, err = registry.Registry(c.GetProtocol(), addrUrl, rt.KubeClient())
Review Comment:
If it's just used here, then I think we need to think of how to refactor it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: impl cache bootstrap [dubbo-kubernetes]
Posted by "ev1lQuark (via GitHub)" <gi...@apache.org>.
ev1lQuark commented on code in PR #138:
URL: https://github.com/apache/dubbo-kubernetes/pull/138#discussion_r1446861065
##########
pkg/admin/bootstrap.go:
##########
@@ -103,7 +103,7 @@ func RegisterOther(rt core_runtime.Runtime) error {
if err != nil {
panic(err)
}
- config.AdminRegistry, err = registry.Registry(c.GetProtocol(), addrUrl) // TODO: support k8s
+ config.AdminRegistry, config.Cache, err = registry.Registry(c.GetProtocol(), addrUrl, rt.KubeClient())
Review Comment:
It is used at [here](https://github.com/apache/dubbo-kubernetes/blob/f89cc80d96207f70daddee1936403f243b257f3a/pkg/admin/services/generic_service_Impl.go#L35).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: impl cache bootstrap [dubbo-kubernetes]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #138:
URL: https://github.com/apache/dubbo-kubernetes/pull/138#issuecomment-1883104548
## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`c3ad915`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/c3ad915bd8b24e3f1f8b9c29a285e37c9a537ff5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.07% compared to head [(`5f2192b`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.07%.
> :exclamation: Current head 5f2192b differs from pull request most recent head 949406c. Consider uploading reports for the commit 949406c to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 49.07% 49.07%
=======================================
Files 147 147
Lines 9457 9457
Branches 41 41
=======================================
Hits 4641 4641
Misses 4288 4288
Partials 528 528
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org