[jira] Closed: (MSITE-284) getRelativePath fails on non-normalized inputs

["Dennis Lundberg (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MSITE-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MSITE-284.
---------------------------------

         Assignee: Dennis Lundberg
       Resolution: Fixed
    Fix Version/s: 2.0-beta-7

The patch has been modified and applied to maven-doxia-tools, where this code now resides. Thanks!

Please check r640091 that everything looks OK.

> getRelativePath fails on non-normalized inputs
> ----------------------------------------------
>
>                 Key: MSITE-284
>                 URL: http://jira.codehaus.org/browse/MSITE-284
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>          Components: relative links
>    Affects Versions: 2.0-beta-6
>            Reporter: Benjamin Bentmann
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.0-beta-7
>
>         Attachments: normalized-paths.patch
>
>
> The algo in AbstractSiteMojo.getRelativePath() assumes that its input paths are both normalized and produces wrong output if it gets something like "dir/../dir". Attached is a simple unit test and a fix for the method itself.
> FYI, non-normalized path are easily created by Maven if one has a non-Maven-like directory layout with
>   project/
>     project-parent/
>     project-module-1/
> where simple string/path concatenation produces a path like "project/project-module-1/../project-parent" when referencing the parent POM from the module POM.
> Path/URL transformations like normalization/relativization/resolution are quite ubiquitous in Maven. Isn't there a nice util class around that prevents each and every plugin developer to reimplement those error-prone methods?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira