You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/11 15:36:31 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
weizhouapache opened a new pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101
### Description
This PR fixes #6084
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070645655
> Should accounts be allowed to do this? We generally don't expose any implementation/hardware settings to end accounts or domains.
@rohityadavcloud
account-level setting can only be set by root admin in the past.
but with #4339, domain admin can change them as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070860322
> Hi Wei, Could you explain why we would want this. on the face of it, it doesn't seem a good idea. One of the biggest points of a Cloud Management Platform is to abstract the underlying hardware & hypervisor away from the users.
Hi @PaulAngus
we have a customer issue. the customer has two clusters with different hypervisors. They want to deploy user VMs in the cluster A with hypervisor A but want the VR to be deployed in the cluster B with hypervisor B.
since many years ago, cloudstack tries to deploy network VR using same deployment destination as user vm, the VRs are created with the same hypervisor as user vm, they cannot be started to another cluster because the hypervisor is different.
The workaround is, deploy another user vm C in cluster B, after network VR is started in cluster B, deploy the user vm in Cluster A. The PR aims to provide a resolution.
As said before, The scope of the new setting can be discussed. The higher level means bigger impact (e.g. Zone), the lower level means smaller impact (e.g. Network Offering or Account).
CloudStack has some settings which impact the vm/vr allocation on hardware, some are visible to users (e.g. affinity group,dedication), some are not (e.g. host tags, storage tags). the account setting (not limited to this new setting) are not visible to users, but yes to root admins and domain admins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1065263500
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1068951583
@nvazquez @borisstoyanov
I have updated this PR to add an account-level setting: router.hypervisor.type
If it is set, the virtual router will be deployed with the specified hypervisor type.
the scope of the setting is `Account` for now, because the `router.service.offering` is also an account setting.
we can discuss which scope is the best, the options are `Zone`, `Cluster`, `Domain`, `Account`, a detail to `Network Offering` (need to create a new network offering), a new field or detail to `Service Offering`, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1065338334
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070846694
Hi Wei,
Could you explain why we would want this. on the face of it, it doesn't seem a good idea.
One of the biggest points of a Cloud Management Platform is to abstract the underlying hardware & hypervisor away from the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1065226739
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070846694
Hi Wei,
Could you explain why we would want this. on the face of it, it doesn't seem a good idea.
One of the biggest points of a Cloud Management Platform is to abstract the underlying hardware & hypervisor away from the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1065229508
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070975569
> @weizhouapache could we use tags/labels with some way to link/specify them in-network offerings be used as a means of specifying preferred hypervisor for router instead? So for ex. users using Network Offering A will get VR deployed in Hypervisor X...
@rohityadavcloud
yes, that's an option, similar as what I posted in https://github.com/apache/cloudstack/pull/6101#issuecomment-1068951583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070911714
@weizhouapache could we use tags/labels with some way to link/specify them in-network offerings be used as a means of specifying preferred hypervisor for router instead? So for ex. users using Network Offering A will get VR deployed in Hypervisor X...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1065338664
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070606650
Should accounts be allowed to do this? We generally don't expose any implementation/hardware settings to end accounts or domains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070847195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070847195
> Thanks @weizhouapache - I think it could be better if it is a zone-wide setting since it could contain different hypervisors clusters. What do you think @weizhouapache @borisstoyanov?
@nvazquez if it is a zone-wide setting, all networks in the zone will be impacted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070327961
Thanks @weizhouapache - I think it could be better if it is a zone-wide setting since it could contain different hypervisors clusters. What do you think @weizhouapache @borisstoyanov?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1070911714
@weizhouapache could we use tags/labels with some way to link/specify them in-network offerings be used as a means of specifying preferred hypervisor for router instead? So for ex. users using Network Offering A will get VR deployed in Hypervisor X...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6101: server: add default hypervisor to supported hypervisor list of VRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101#issuecomment-1065801619
<b>Trillian test result (tid-3585)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33309 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6101-t3585-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #6101: server: add account-level setting: router.hypervisor.type
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #6101:
URL: https://github.com/apache/cloudstack/pull/6101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org