You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Varlamov (JIRA)" <ji...@apache.org> on 2006/09/06 12:15:23 UTC
[jira] Commented: (HARMONY-1390) DRLVM doesn't work in subdirectory
of jre/bin
[ http://issues.apache.org/jira/browse/HARMONY-1390?page=comments#action_12432800 ]
Alexey Varlamov commented on HARMONY-1390:
------------------------------------------
Generally patch looks very good, but I have the following observations:
1) IIUC the notorious hythr lib assumed to be taken from classlib - not sure how this can work nowadays, when the DRLVM will be deployed to HDK.
2) clear_vm_arguments() in vm\vmcore\src\init\parse_arguments.cpp survived the cleanup, but it is not needed anymore.
3) parse_cmd_arguments() declaration remained in vm/vmcore/include/init.h
> DRLVM doesn't work in subdirectory of jre/bin
> ---------------------------------------------
>
> Key: HARMONY-1390
> URL: http://issues.apache.org/jira/browse/HARMONY-1390
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Win, Linux
> Reporter: Evgueni Brevnov
> Attachments: classlib.launcher.patch, drlvm.launcher.patch
>
>
> HI All,
> Good news! I have a patch to run DRLVM with the classlib's launcher
> (I've checked Hello and Eclipse applications on Windows only).
> Actually, there are two patches. The first one is for classlib which
> changes vm default directory to drlvm. The second one is for build
> system and VM itself. Unfortunatelly, it is impossible to eliminate
> all problems in a short period of time. There is still a bunch of work
> in initialization and jni modules. So this patch is just a one more
> step to our goal.
> The vm patch is quite heavy so I attach it and classlib patch.
> Hope it will work not only for me :-)
> - Hide quoted text -
> On 9/5/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
> >
> >
> > Salikh Zakirov wrote:
> > > Andrey Chernyshev wrote:
> > >> 1. Fix the DRLVM layout - rename vmcore to "harmonyvm" and move
> > >> ..dll/.so into the "default" subdirectory such that one doesn't have to
> > >> type -vm and -vmdir options;
> > >
> > > While would you want to rename DRLVM to Harmony VM?
> > > It feels to me like claiming DRLVM to be "the only" Harmony VM.
> > > On the contrary, I thought Harmony project is about *encouraging* diversity.
> > >
> > > I think having library named libdrlvm.so would be much better.
> >
> > No - the launcher picks up the vm from "harmonyvm.dll" (or .so) so
> > that's what we'll name it.
> >
> > Then it makes it easy. put J9 in jre/bin/j9 and drlvm in jre/bin/drlvm
> > and then
> >
> > java -vmdir:j9
> >
> > or
> >
> > java -vmdir:drlvm
> >
> >
> > etc
> >
> > geir
> >
> > >
> > >> 2. Exclude building of the "original" launcher from the DRLVM build -
> > >> it currently conflicts with the classlib launcher (both are called
> > >> "java").
> > >>
> > >> 3. Aside from the hythread, it may also have a sense to make the
> > >> classlib and DRLVM using the same zlib dll/so (preferably the system
> > >> one).
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira