You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/07 13:05:28 UTC

Re: Review Request 41856: [WIP][MESOS-3892] Helper functions to get allocation slack.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 8:05 p.m.)


Review request for mesos and Guangya Liu.


Summary (updated)
-----------------

[WIP][MESOS-3892] Helper functions to get allocation slack.


Bugs: MESOS-3892
    https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
-------

Helper functions to get allocation slack


Diffs
-----

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
-------


Thanks,

Klaus Ma


Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/#review113387
-----------------------------------------------------------



src/slave/slave.cpp (line 3872)
<https://reviews.apache.org/r/41856/#comment173994>

    s/staeless/stateless


- Jian Qiu


On 一月 7, 2016, 1:09 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41856/
> -----------------------------------------------------------
> 
> (Updated 一月 7, 2016, 1:09 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
>     https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Helper functions to get allocation slack
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
>   include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
>   src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/41856/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Re: Review Request 41856: Added helper functions to get allocation slack.

Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
-----------------------------------------------------------

(Updated Jan. 8, 2016, 2:53 p.m.)


Review request for mesos and Guangya Liu.


Summary (updated)
-----------------

Added helper functions to get allocation slack.


Bugs: MESOS-3892
    https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
-------

Helper functions to get allocation slack


Diffs
-----

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
-------


Thanks,

Klaus Ma


Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
-----------------------------------------------------------

(Updated Jan. 8, 2016, 2:51 p.m.)


Review request for mesos and Guangya Liu.


Changes
-------

rebase


Bugs: MESOS-3892
    https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
-------

Helper functions to get allocation slack


Diffs (updated)
-----

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
-------


Thanks,

Klaus Ma


Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 9:09 p.m.)


Review request for mesos and Guangya Liu.


Bugs: MESOS-3892
    https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
-------

Helper functions to get allocation slack


Diffs (updated)
-----

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
-------


Thanks,

Klaus Ma


Re: Review Request 41856: WIP: Added helper functions to get allocation slack.

Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 8:34 p.m.)


Review request for mesos and Guangya Liu.


Summary (updated)
-----------------

WIP: Added helper functions to get allocation slack.


Bugs: MESOS-3892
    https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
-------

Helper functions to get allocation slack


Diffs
-----

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
-------


Thanks,

Klaus Ma