[jira] [Commented] (SSHD-746) Seems IPv6 addresses are not supported

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317256#comment-16317256 ] 

ASF GitHub Bot commented on SSHD-746:
-------------------------------------

GitHub user daik opened a pull request:

    https://github.com/apache/mina-sshd/pull/42

    SSHD-746 add minimal support so IPv6 addresses do not throw exceptions.

    This is the bare minimum required to make it possible to connect to hosts identified by an IPv6 address. I have tested this to confirm it works. The aim here is to make it possible (i.e no exceptions thrown) to connect to hosts defined by only an IPv6 address.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daik/mina-sshd master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit 3e429dc5fa56d8759ad90ee1d822889c59ed62c4
Author: Daniel Kjellin <dk...@...>
Date:   2018-01-08T22:34:13Z

    SSHD-746 add minimal support so IPv6 addresses do not throw exceptions.

----


> Seems IPv6 addresses are not supported
> --------------------------------------
>
>                 Key: SSHD-746
>                 URL: https://issues.apache.org/jira/browse/SSHD-746
>             Project: MINA SSHD
>          Issue Type: New Feature
>    Affects Versions: 1.2.0
>            Reporter: Stephen Connolly
>            Priority: Minor
>
> Seems a lot of the code is not aware of IPv6 patterns
> {code}
> java.lang.IllegalArgumentException: Invalid host pattern char in 0:0:0:0:0:0:0:1
> 	at org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:138)
> 	at org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:127)
> 	at org.apache.sshd.client.config.hosts.HostPatternsHolder.toPattern(HostPatternsHolder.java:247)
> 	at org.apache.sshd.client.config.hosts.HostPatternsHolder.parsePatterns(HostPatternsHolder.java:221)
> 	at org.apache.sshd.client.config.hosts.HostConfigEntry.setHost(HostConfigEntry.java:138)
> 	at org.apache.sshd.client.config.hosts.HostConfigEntry.<init>(HostConfigEntry.java:123)
> 	at org.apache.sshd.client.SshClient.connect(SshClient.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)