[jira] [Commented] (TAJO-518) tajo-algebra and ProjectionPushDownRule code cleanup

["Tajo QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874995#comment-13874995 ] 

Tajo QA commented on TAJO-518:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12623684/TAJO-518.patch
  against master revision ebb12b7.

    {color:green}+1 @author.{color}  The patch does not contain any @author tags.

    {color:red}-1 tests included.{color}  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac.{color}  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 164 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in tajo-algebra tajo-core/tajo-core-backend.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/57//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/57//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-algebra.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/57//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/57//console

This message is automatically generated.

> tajo-algebra and ProjectionPushDownRule code cleanup
> ----------------------------------------------------
>
>                 Key: TAJO-518
>                 URL: https://issues.apache.org/jira/browse/TAJO-518
>             Project: Tajo
>          Issue Type: Bug
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Trivial
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-518.patch
>
>
> This patch fixes some potential bugs commented in TAJO-501 reviews.
> https://reviews.apache.org/r/17040/



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)