Re: [PR] [AURON #1346] Change spark.auron.enable to spark.auron.enabled [auron]

["wForget (via GitHub)" <gi...@apache.org>]

wForget commented on PR #1347:
URL: https://github.com/apache/auron/pull/1347#issuecomment-3336813032

   > Wouldn't this break existing production workflows? We should try to build some level of backwards compatibility here. @wForget WDYT?
   
   I don't think we need to keep it compatible in the first upcoming apache version, because we changed the naming of all configuration keys, before auron entered apache it was spark.blaze.xxx and its default value was true.
   
   > Also, I'm not sure if I follow why this change is necessary.
   
   Ensure the same naming style as spark/flank, like:
   
   https://github.com/apache/spark/blob/cb283404d3b229f18b8508793098aa6759af46a7/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L573
   
   https://nightlies.apache.org/flink/flink-docs-release-2.1/docs/deployment/config/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org