[jira] [Commented] (STORM-1099) worker childopts cannot accept arraylist of strings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949580#comment-14949580 ] 

ASF GitHub Bot commented on STORM-1099:
---------------------------------------

GitHub user ppoulosk opened a pull request:

    https://github.com/apache/storm/pull/791

    [STORM-1099]  Fix worker childopts as arraylist of strings

    This fixes the bug by changing supervisor.clj to operate on any sequential, not just a list.  
    
    A unit test was added to verify that this works.  I ran the unit test without the supervisor change, and it did fail.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppoulosk/storm STORM-1099

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/791.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #791
    
----
commit 103125d428e13aed20acbd7881ab8b1aaa423ed9
Author: Paul Poulosky <pp...@yahoo-inc.com>
Date:   2015-10-08T22:51:34Z

    Merge pull request #579 from ppoulosk/YSTORM-2270
    
    [YSTORM-2270]  Fix arraylist of strings as config value for childopts

----


> worker childopts cannot accept arraylist of strings
> ---------------------------------------------------
>
>                 Key: STORM-1099
>                 URL: https://issues.apache.org/jira/browse/STORM-1099
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Paul Poulosky
>            Assignee: Paul Poulosky
>
> This used to work on 0.9, but is broken in 0.10.
> If a customer attempts to add a array of strings as a config for topology.worker.childopts, like the following.
> {noformat}
>       config.put("topology.worker.childopts", Arrays.asList("-Xmx1g", "-Dmy.boxus.parameter=mybogusvalue"));
> {noformat}
> The topology will not launch because "[-Xmx1g" will be an argument to the jvm when the supervisor launches it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)