[GitHub] [pulsar] sijie commented on a change in pull request #6868: [issue #6765] Expose definition flags to function

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #6868:
URL: https://github.com/apache/pulsar/pull/6868#discussion_r426937125



##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -91,6 +91,8 @@ message ConsumerSpec {
         int32 value = 1;
     }
     ReceiverQueueSize receiverQueueSize = 4;
+    bool jsr310ConversionEnabled = 5;

Review comment:
       I don't think it is a good design to add these two settings directly. Because these two settings are only applied to AVRO or Struct schemas. It doesn't provide any extensibility to the framework of Pulsar functions. We should provide the ability to allow specifying `properties` for the schema for the input topic and `properties` for the schema for the output topic.
   
   So ideally, it should be:
   
   `map<string, string> schemaProperties = 6;`.
   
   

##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -91,6 +91,8 @@ message ConsumerSpec {
         int32 value = 1;
     }
     ReceiverQueueSize receiverQueueSize = 4;
+    bool jsr310ConversionEnabled = 5;

Review comment:
       We should also add the `schemaProperties` to both `SourceSpec` and `SinkSpec`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org