You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/04/24 22:13:31 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3474: Converts Edge/Mid header rewrite, regexremap, remaptext and tr request/response header text inputs to textareas

ocket8888 commented on a change in pull request #3474: Converts Edge/Mid header rewrite, regexremap, remaptext and tr request/response header text inputs to textareas
URL: https://github.com/apache/trafficcontrol/pull/3474#discussion_r278322550
 
 

 ##########
 File path: docs/source/admin/traffic_ops/using.rst
 ##########
 @@ -432,9 +432,9 @@ The fields in the :term:`Delivery Service` view are:
 |                                            |                                                                                                                                                                        |
 |                                            | See :ref:`header-rewrite`. [1]_                                                                                                                                        |
 +--------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
-| Traffic Router Additional Response Headers | List of header name:value pairs separated by __RETURN__. Listed pairs will be included in all TR HTTP responses.                                                       |
+| Traffic Router Additional Response Headers | List of header name:value pairs. One name:value pair per line. Listed pairs will be included in all Traffic Router HTTP(S) responses.                                  |
 +--------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
-| Traffic Router Log Request Headers         | List of header keys separated by __RETURN__. Listed headers will be included in TR access log entries under the “rh=” token.                                           |
+| Traffic Router Log Request Headers         | List of header keys. One header key per line. Listed headers will be included in Traffic Router access log entries under the "rh=" token.                              |
 
 Review comment:
   I don't really think it's necessary to update the docs for a dead UI :P
   
   Not that I'm saying you should revert this - it's fine, just for future reference.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services