You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2015/07/24 19:33:04 UTC
[jira] [Commented] (SOLR-7804) TestCloudPivotFacet failures:
expected: but was:
[ https://issues.apache.org/jira/browse/SOLR-7804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640773#comment-14640773 ]
Hoss Man commented on SOLR-7804:
--------------------------------
There's two distinct types of failures here..
* assertPivotCountsAreCorrect fails directly (and very early in it's cycle) because {{num pivots expected:<X> but was:<X-1>}}
** this is a straightforward test bug - it's not accounting for the 1 in ~1000 chance that it will generate the exact same "facet.pivot" param twice in a single request
* assertNumFound fails with {{expected:<X> but was:<X+Y>
** this is ... something else. it's not immediately obvious to me why these are failing
*** in both of the examples give so far, the specific failure msg indicates that it's trying to verify the count from a "missing" constraint (ie: dos that do not have a pivot constrain value) and when adding an {{fq=-fieldname:[* TO *]}} to the original query, it gets _more_ documents then the facet said it should.
*** besides the fact that they are both the "missing" counts, the only other commonality that jumps out at me is that facet.mincount is used in both queries, and in both cases the facet.mincount is just slightly below the count returned -- making me wonder if there is a bug in how the we're dealing with counts from individual shards below the mincount? (pure speculation)
*** i should not explicitly that in one of the failures, the facet.limit=5 and the incorrect count is from a boolean field which is the very first field in the pivot -- so refinement shouldn't be a factor in whatever is going wrong.
----
I've got a trivial patch for the first problem that i'll commit soon -- it doens't affect the entropy of the randomized test, so the other seeds (for the second problem) still fail and can be used to continue to test that remaining problem...
{noformat}
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestCloudPivotFacet -Dtests.method=test -Dtests.seed=957BC6861F510BE -Dtests.slow=true -Dtests.locale=sr_BA -Dtests.timezone=America/Guadeloupe -Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] FAILURE 36.2s J3 | TestCloudPivotFacet.test <<<
[junit4] > Throwable #1: java.lang.AssertionError: {main(facet=true&facet.pivot=pivot_b%2Cpivot_f%2Cpivot_dt1&facet.pivot=%7B%21stats%3Dst3%7Dpivot_td%2Cpivot_z_s1&facet.limit=5&facet.pivot.mincount=16&facet.missing=true&facet.sort=index&facet.overrequest.ratio=1.1832508),extra(rows=0&q=*%3A*&stats=true&stats.field=%7B%21key%3Dsk1+tag%3Dst1%2Cst2%7Dpivot_tl&stats.field=%7B%21key%3Dsk2+tag%3Dst2%2Cst3%7Dpivot_tdt1&stats.field=%7B%21key%3Dsk3+tag%3Dst3%2Cst4%7Ddense_pivot_y_s&_test_min=16&_test_miss=true&_test_sort=index)} ==> pivot_b,pivot_f,pivot_dt1: {params(rows=0),defaults({main(rows=0&q=*%3A*&stats=true&stats.field=%7B%21key%3Dsk1+tag%3Dst1%2Cst2%7Dpivot_tl&stats.field=%7B%21key%3Dsk2+tag%3Dst2%2Cst3%7Dpivot_tdt1&stats.field=%7B%21key%3Dsk3+tag%3Dst3%2Cst4%7Ddense_pivot_y_s&_test_min=16&_test_miss=true&_test_sort=index),extra(fq=-pivot_b%3A%5B*+TO+*%5D)})} expected:<17> but was:<22>
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestCloudPivotFacet -Dtests.method=test -Dtests.seed=4FE0B7EDE128DBAA -Dtests.slow=true -Dtests.locale=ga -Dtests.timezone=America/Detroit -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
[junit4] FAILURE 34.7s J10 | TestCloudPivotFacet.test <<<
[junit4] > Throwable #1: java.lang.AssertionError: {main(facet=true&facet.pivot=%7B%21stats%3Dst2%7Dpivot_f%2Cdense_pivot_i1&facet.pivot=pivot_f%2Cdense_pivot_x_s1%2Cbogus_not_in_any_doc_s&facet.limit=13&facet.pivot.mincount=5&facet.missing=true&facet.sort=index&facet.overrequest.count=0&facet.overrequest.ratio=0),extra(rows=0&q=*%3A*&stats=true&stats.field=%7B%21key%3Dsk1+tag%3Dst1%2Cst2%7Dpivot_x_s1&stats.field=%7B%21key%3Dsk2+tag%3Dst2%2Cst3%7Dpivot_i1&stats.field=%7B%21key%3Dsk3+tag%3Dst3%2Cst4%7Dpivot_dt1&_test_min=5&_test_miss=true&_test_sort=index)} ==> pivot_f,dense_pivot_i1: {params(rows=0),defaults({main({main(rows=0&q=*%3A*&stats=true&stats.field=%7B%21key%3Dsk1+tag%3Dst1%2Cst2%7Dpivot_x_s1&stats.field=%7B%21key%3Dsk2+tag%3Dst2%2Cst3%7Dpivot_i1&stats.field=%7B%21key%3Dsk3+tag%3Dst3%2Cst4%7Dpivot_dt1&_test_min=5&_test_miss=true&_test_sort=index),extra(fq=%7B%21term+f%3Dpivot_f%7D0.33333334)}),extra(fq=-dense_pivot_i1%3A%5B*+TO+*%5D)})} expected:<6> but was:<7>
{noformat}
> TestCloudPivotFacet failures: expected:<X> but was:<Y>
> ------------------------------------------------------
>
> Key: SOLR-7804
> URL: https://issues.apache.org/jira/browse/SOLR-7804
> Project: Solr
> Issue Type: Bug
> Components: faceting
> Affects Versions: 5.3, Trunk
> Reporter: Steve Rowe
>
> A couple failures recently on my Jenkins (Linux), both on branch_5x and trunk - here's one on trunk: [http://jenkins.sarowe.net/job/Lucene-Solr-tests-trunk/766/], and another on branch_5x: [http://jenkins.sarowe.net/job/Lucene-Solr-tests-5.x-Java8/546/].
> I reproduced another branch_5x failure from a few days ago (Jenkins job has been removed already) on OS X, using both java7 and java8:
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestCloudPivotFacet -Dtests.method=test -Dtests.seed=D8E5204E25B3DB16 -Dtests.slow=true -Dtests.locale=es_PA -Dtests.timezone=America/El_Salvador -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> [junit4] FAILURE 46.6s | TestCloudPivotFacet.test <<<
> [junit4] > Throwable #1: java.lang.AssertionError: {main(facet=true&facet.pivot=%7B%21stats%3Dst0%7Dpivot_ti1&facet.pivot=%7B%21stats%3Dst0%7Dpivot_ti1&facet.limit=4&facet.offset=6&facet.missing=true&facet.overrequest.ratio=-0.9744149),extra(rows=0&q=id%3A%5B*+TO+448%5D&fq=id%3A%5B*+TO+516%5D&_test_miss=true)} num pivots expected:<2> but was:<1>
> [junit4] > at __randomizedtesting.SeedInfo.seed([D8E5204E25B3DB16:50B11F948B4FB6EE]:0)
> [junit4] > at org.apache.solr.cloud.TestCloudPivotFacet.assertPivotCountsAreCorrect(TestCloudPivotFacet.java:251)
> [junit4] > at org.apache.solr.cloud.TestCloudPivotFacet.test(TestCloudPivotFacet.java:228)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:960)
> [junit4] > at org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:935)
> [junit4] > at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org