You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/06/06 06:35:44 UTC

[GitHub] [lucene] zacharymorn opened a new pull request #171: LUCENE-9976: Fix WANDScorer assertion error

zacharymorn opened a new pull request #171:
URL: https://github.com/apache/lucene/pull/171


   # Description
   Fix WANDScorer assertion error
   
   # Solution
   Update the assertion as condition (tailMaxScore >= minCompetitiveScore) && (tailSize < minShouldMatch) are valid now
   
   # Tests
   Passed `gradlew test -Ptests.iters=10 --tests TestExpressionSorts.testQueries -Dtests.seed=FF571CE915A0955:537BBD158B33BCFB -Dtests.multiplier=2 -Dtests.nightly=true -Dtests.slow=true -Dtests.asserts=true -p lucene/expressions/`
   
   Passed `./gradlew check -Pvalidation.git.failOnModified=false -Dtests.nightly=true`
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] zacharymorn commented on pull request #171: LUCENE-9976: Fix WANDScorer assertion error

Posted by GitBox <gi...@apache.org>.
zacharymorn commented on pull request #171:
URL: https://github.com/apache/lucene/pull/171#issuecomment-857446169


   > Thank you!
   
   Thanks Adrien for the review and approval!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] zacharymorn merged pull request #171: LUCENE-9976: Fix WANDScorer assertion error

Posted by GitBox <gi...@apache.org>.
zacharymorn merged pull request #171:
URL: https://github.com/apache/lucene/pull/171


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org