You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "David Turanski (JIRA)" <ji...@codehaus.org> on 2005/04/07 17:08:46 UTC
[jira] Created: (MPECLIPSE-87) syntax problem using classpath exclusions with Eclipse 3.0
syntax problem using classpath exclusions with Eclipse 3.0
----------------------------------------------------------
Key: MPECLIPSE-87
URL: http://jira.codehaus.org/browse/MPECLIPSE-87
Project: maven-eclipse-plugin
Type: Bug
Environment: Windows XP, Eclipse 3.0 Eclipse Plugin 1.7
Reporter: David Turanski
Priority: Minor
Attachments: maven-eclipse-plugin-1.7.1.jar
Here is an excerpt from a sample project.xml
<sourceDirectory>src/java</sourceDirectory>
<sourceModifications>
<sourceModification>
<className>NonExistentDummyClass</className>
<excludes>
<exclude>com/unisys/comms/jdal/ejb/servlet/test/*</exclude>
<exclude>com/unisys/comms/jdal/connectors/ucc/test/*</exclude>
<exclude>com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*</exclude>
</excludes>
</sourceModification>
</sourceModifications>
The 1.7 plugin will generate the following entry in .classpath
<classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*,com/unisys/comms/jdal/connectors/ucc/test/*,com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
Note the comma is used as a separator and hard-coded in classpath.jelly
Eclipse 3.0 does not parse this correctly. It accepts the string, but it doesn't have any effect. Eclipse expects a pipe [ | ] separator instead, e.g.:
<classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*|com/unisys/comms/jdal/connectors/ucc/test/*|com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
Recommend the following patch
Add the following to plugin.properties
maven.eclipse.separator.exclude=|
Modify line 42 in classpath.jelly to reference this property.(see attached):
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Reopened: (MPECLIPSE-87) syntax problem using classpath exclusions with Eclipse 3.0
Posted by "David Turanski (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPECLIPSE-87?page=all ]
David Turanski reopened MPECLIPSE-87:
-------------------------------------
I just tested it again in 1.9. Here is the code in classpath.jelly:
<j:set var="excluding" value=""/>
<j:forEach var="sm" items="${pom.build.sourceModifications}">
<ant:available property="classPresent" classname="${sm.className}"/>
<j:if test="${classPresent != 'true'}">
<j:forEach var="exclude" items="${sm.excludes}">
<j:choose>
<j:when test="${excluding.length() == 0}">
<j:set var="excluding" value="${exclude}"/>
</j:when>
<j:otherwise>
<j:set var="excluding" value="${excluding},${exclude}"/>
</j:otherwise>
</j:choose>
</j:forEach>
</j:if>
</j:forEach>
Should be
<j:set var="excluding" value="${excluding} | ${exclude}"/>
> syntax problem using classpath exclusions with Eclipse 3.0
> ----------------------------------------------------------
>
> Key: MPECLIPSE-87
> URL: http://jira.codehaus.org/browse/MPECLIPSE-87
> Project: maven-eclipse-plugin
> Type: Bug
> Environment: Windows XP, Eclipse 3.0 Eclipse Plugin 1.7
> Reporter: David Turanski
> Assignee: fabrizio giustina
> Priority: Minor
> Fix For: 1.9
> Attachments: maven-eclipse-plugin-1.7.1.jar
>
> Original Estimate: 30 minutes
> Remaining: 30 minutes
>
> Here is an excerpt from a sample project.xml
> <sourceDirectory>src/java</sourceDirectory>
> <sourceModifications>
> <sourceModification>
> <className>NonExistentDummyClass</className>
> <excludes>
> <exclude>com/unisys/comms/jdal/ejb/servlet/test/*</exclude>
> <exclude>com/unisys/comms/jdal/connectors/ucc/test/*</exclude>
> <exclude>com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*</exclude>
> </excludes>
> </sourceModification>
> </sourceModifications>
> The 1.7 plugin will generate the following entry in .classpath
> <classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*,com/unisys/comms/jdal/connectors/ucc/test/*,com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
> Note the comma is used as a separator and hard-coded in classpath.jelly
> Eclipse 3.0 does not parse this correctly. It accepts the string, but it doesn't have any effect. Eclipse expects a pipe [ | ] separator instead, e.g.:
> <classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*|com/unisys/comms/jdal/connectors/ucc/test/*|com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
> Recommend the following patch
> Add the following to plugin.properties
> maven.eclipse.separator.exclude=|
> Modify line 42 in classpath.jelly to reference this property.(see attached):
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPECLIPSE-87) syntax problem using classpath exclusions with Eclipse 3.0
Posted by "fabrizio giustina (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPECLIPSE-87?page=all ]
fabrizio giustina closed MPECLIPSE-87:
--------------------------------------
Assign To: fabrizio giustina
Resolution: Fixed
Fix Version: 1.9
This was already fixed in svn a long time ago
> syntax problem using classpath exclusions with Eclipse 3.0
> ----------------------------------------------------------
>
> Key: MPECLIPSE-87
> URL: http://jira.codehaus.org/browse/MPECLIPSE-87
> Project: maven-eclipse-plugin
> Type: Bug
> Environment: Windows XP, Eclipse 3.0 Eclipse Plugin 1.7
> Reporter: David Turanski
> Assignee: fabrizio giustina
> Priority: Minor
> Fix For: 1.9
> Attachments: maven-eclipse-plugin-1.7.1.jar
>
> Original Estimate: 30 minutes
> Remaining: 30 minutes
>
> Here is an excerpt from a sample project.xml
> <sourceDirectory>src/java</sourceDirectory>
> <sourceModifications>
> <sourceModification>
> <className>NonExistentDummyClass</className>
> <excludes>
> <exclude>com/unisys/comms/jdal/ejb/servlet/test/*</exclude>
> <exclude>com/unisys/comms/jdal/connectors/ucc/test/*</exclude>
> <exclude>com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*</exclude>
> </excludes>
> </sourceModification>
> </sourceModifications>
> The 1.7 plugin will generate the following entry in .classpath
> <classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*,com/unisys/comms/jdal/connectors/ucc/test/*,com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
> Note the comma is used as a separator and hard-coded in classpath.jelly
> Eclipse 3.0 does not parse this correctly. It accepts the string, but it doesn't have any effect. Eclipse expects a pipe [ | ] separator instead, e.g.:
> <classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*|com/unisys/comms/jdal/connectors/ucc/test/*|com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
> Recommend the following patch
> Add the following to plugin.properties
> maven.eclipse.separator.exclude=|
> Modify line 42 in classpath.jelly to reference this property.(see attached):
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPECLIPSE-87) syntax problem using classpath exclusions with Eclipse 3.0
Posted by "fabrizio giustina (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPECLIPSE-87?page=all ]
fabrizio giustina closed MPECLIPSE-87:
--------------------------------------
Resolution: Fixed
Fix Version: (was: 1.9)
1.10
Thanks for verifying this: you are right, the path separator was fixed for everything except for sourceModifications.
Fix committed to svn for 1.10
> syntax problem using classpath exclusions with Eclipse 3.0
> ----------------------------------------------------------
>
> Key: MPECLIPSE-87
> URL: http://jira.codehaus.org/browse/MPECLIPSE-87
> Project: maven-eclipse-plugin
> Type: Bug
> Environment: Windows XP, Eclipse 3.0 Eclipse Plugin 1.7
> Reporter: David Turanski
> Assignee: fabrizio giustina
> Priority: Minor
> Fix For: 1.10
> Attachments: maven-eclipse-plugin-1.7.1.jar
>
> Original Estimate: 30 minutes
> Remaining: 30 minutes
>
> Here is an excerpt from a sample project.xml
> <sourceDirectory>src/java</sourceDirectory>
> <sourceModifications>
> <sourceModification>
> <className>NonExistentDummyClass</className>
> <excludes>
> <exclude>com/unisys/comms/jdal/ejb/servlet/test/*</exclude>
> <exclude>com/unisys/comms/jdal/connectors/ucc/test/*</exclude>
> <exclude>com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*</exclude>
> </excludes>
> </sourceModification>
> </sourceModifications>
> The 1.7 plugin will generate the following entry in .classpath
> <classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*,com/unisys/comms/jdal/connectors/ucc/test/*,com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
> Note the comma is used as a separator and hard-coded in classpath.jelly
> Eclipse 3.0 does not parse this correctly. It accepts the string, but it doesn't have any effect. Eclipse expects a pipe [ | ] separator instead, e.g.:
> <classpathentry excluding="com/unisys/comms/jdal/ejb/servlet/test/*|com/unisys/comms/jdal/connectors/ucc/test/*|com/unisys/comms/jdal/connectors/cuc/test/httpclientdrv/*" kind="src" path="src\java">
> Recommend the following patch
> Add the following to plugin.properties
> maven.eclipse.separator.exclude=|
> Modify line 42 in classpath.jelly to reference this property.(see attached):
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org