[GitHub] [ignite] antonovsergey93 commented on a change in pull request #7924: IGNITE-13144: minor usability and code improvements in a cluster read-only mode.

[GitBox <gi...@apache.org>]

antonovsergey93 commented on a change in pull request #7924:
URL: https://github.com/apache/ignite/pull/7924#discussion_r442958036



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/GridClusterStateProcessor.java
##########
@@ -924,14 +901,11 @@ protected IgniteCheckedException concurrentStateChangeError(ClusterState state,
                 throw new IgniteException("Node with BaselineTopology cannot join" +
                     " mixed cluster running in compatibility mode");
 
-            globalState = (DiscoveryDataClusterState) data.commonData();
+            globalState = (DiscoveryDataClusterState)data.commonData();
 
             compatibilityMode = true;
 
-            ctx.cache().context().readOnlyMode(readOnly(globalState.state()));
-
-            if (readOnly(globalState.state()))
-                ctx.cache().context().database().forceCheckpoint("Cluster read-only mode enabled");
+            ctx.cache().context().readOnlyMode(globalState.state() == ACTIVE_READ_ONLY);

Review comment:
       I've added force checkpoint by mistake. I thought that it could be helpful for the cluster backup in read-only mode. But, I forgot about rebalance and other inner activities. So, force checkpoint not needed there. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org