[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5421: Implement/fix Eq and Hash for Expr and LogicalPlan

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5421:
URL: https://github.com/apache/arrow-datafusion/pull/5421#discussion_r1123719124


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1515,8 +1515,30 @@ pub struct TableScan {
     pub fetch: Option<usize>,
 }
 
+impl PartialEq for TableScan {
+    fn eq(&self, other: &Self) -> bool {
+        self.table_name == other.table_name

Review Comment:
   Upon consideration within a single plan, the `table_name` should be unique. I was originally worried about the case where two TableScan's that had different `source`s but all other fields are the same resulting in a false positive. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org