You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/07/04 20:06:21 UTC
(superset) branch master updated: refactor(dashboard): rename supersetCanCSV to supersetCanDownload (#24290) (#39118)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 004c401c973 refactor(dashboard): rename supersetCanCSV to supersetCanDownload (#24290) (#39118)
004c401c973 is described below
commit 004c401c973566b0106b5370d4b7c7be86633394
Author: Pawan <42...@users.noreply.github.com>
AuthorDate: Sat Jul 4 21:06:14 2026 +0100
refactor(dashboard): rename supersetCanCSV to supersetCanDownload (#24290) (#39118)
Co-authored-by: jaymasiwal <ja...@users.noreply.github.com>
---
superset-frontend/src/dashboard/actions/hydrate.ts | 2 +-
.../components/SliceHeader/SliceHeader.test.tsx | 10 +++++-----
.../src/dashboard/components/SliceHeader/index.tsx | 4 ++--
.../SliceHeaderControls.subdirectory.test.tsx | 2 +-
.../SliceHeaderControls.test.tsx | 2 +-
.../components/SliceHeaderControls/index.tsx | 8 ++++----
.../components/SliceHeaderControls/types.ts | 2 +-
.../components/gridComponents/Chart/Chart.test.tsx | 22 +++++++++++++++++-----
.../components/gridComponents/Chart/Chart.tsx | 6 +++---
9 files changed, 35 insertions(+), 23 deletions(-)
diff --git a/superset-frontend/src/dashboard/actions/hydrate.ts b/superset-frontend/src/dashboard/actions/hydrate.ts
index 079fae53ba8..efca9ff138c 100644
--- a/superset-frontend/src/dashboard/actions/hydrate.ts
+++ b/superset-frontend/src/dashboard/actions/hydrate.ts
@@ -355,7 +355,7 @@ export const hydrateDashboard =
'Superset',
roles,
),
- superset_can_csv: findPermission('can_csv', 'Superset', roles),
+ superset_can_download: findPermission('can_csv', 'Superset', roles),
common: {
// legacy, please use state.common instead
conf: common?.conf,
diff --git a/superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx b/superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
index 58150a2c48b..e5e3efbb568 100644
--- a/superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
@@ -35,7 +35,7 @@ jest.mock('src/dashboard/components/SliceHeaderControls', () => ({
data-cached-dttm={props.cachedDttm}
data-updated-dttm={props.updatedDttm}
data-superset-can-explore={props.supersetCanExplore}
- data-superset-can-csv={props.supersetCanCSV}
+ data-superset-can-download={props.supersetCanDownload}
data-component-id={props.componentId}
data-dashboard-id={props.dashboardId}
data-is-full-size={props.isFullSize}
@@ -144,7 +144,7 @@ const createProps = (overrides: any = {}) => ({
isExpanded: false,
sliceName: 'Vaccine Candidates per Phase',
supersetCanExplore: true,
- supersetCanCSV: true,
+ supersetCanDownload: true,
slice: {
slice_id: MOCKED_CHART_ID,
slice_url: `/explore/?form_data=%7B%22slice_id%22%3A%20${MOCKED_CHART_ID}%7D`,
@@ -222,7 +222,7 @@ test('Should render - default props', () => {
delete props.isExpanded;
delete props.sliceName;
delete props.supersetCanExplore;
- delete props.supersetCanCSV;
+ delete props.supersetCanDownload;
render(<SliceHeader {...props} />, {
useRedux: true,
@@ -250,7 +250,7 @@ test('Should render default props and "call" actions', () => {
delete props.isExpanded;
delete props.sliceName;
delete props.supersetCanExplore;
- delete props.supersetCanCSV;
+ delete props.supersetCanDownload;
render(<SliceHeader {...props} />, {
useRedux: true,
@@ -459,7 +459,7 @@ test('Correct props to "SliceHeaderControls"', () => {
'false',
);
expect(screen.getByTestId('SliceHeaderControls')).toHaveAttribute(
- 'data-superset-can-csv',
+ 'data-superset-can-download',
'true',
);
expect(screen.getByTestId('SliceHeaderControls')).toHaveAttribute(
diff --git a/superset-frontend/src/dashboard/components/SliceHeader/index.tsx b/superset-frontend/src/dashboard/components/SliceHeader/index.tsx
index fe06ca461f1..5c7c232cb2d 100644
--- a/superset-frontend/src/dashboard/components/SliceHeader/index.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeader/index.tsx
@@ -157,7 +157,7 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
sliceName = '',
supersetCanExplore = false,
supersetCanShare = false,
- supersetCanCSV = false,
+ supersetCanDownload = false,
exportPivotCSV,
exportFullCSV,
exportFullXLSX,
@@ -367,7 +367,7 @@ const SliceHeader = forwardRef<HTMLDivElement, SliceHeaderProps>(
exportFullXLSX={exportFullXLSX}
supersetCanExplore={supersetCanExplore}
supersetCanShare={supersetCanShare}
- supersetCanCSV={supersetCanCSV}
+ supersetCanDownload={supersetCanDownload}
componentId={componentId}
dashboardId={dashboardId}
addSuccessToast={addSuccessToast}
diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.subdirectory.test.tsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.subdirectory.test.tsx
index e58f036b3cc..d5dda2a97b8 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.subdirectory.test.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.subdirectory.test.tsx
@@ -98,7 +98,7 @@ const buildProps = (): SliceHeaderControlsProps =>
cachedDttm: [''],
updatedDttm: 0,
supersetCanExplore: true,
- supersetCanCSV: true,
+ supersetCanDownload: true,
componentId: 'CHART-subdir',
dashboardId: 26,
isFullSize: false,
diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
index 571f0f695e1..82d8872d03d 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
@@ -87,7 +87,7 @@ const createProps = (viz_type = VizType.Sunburst) =>
cachedDttm: [''],
updatedDttm: 1617213803803,
supersetCanExplore: true,
- supersetCanCSV: true,
+ supersetCanDownload: true,
componentId: 'CHART-fYo7IyvKZQ',
dashboardId: 26,
isFullSize: false,
diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
index f4ca1656b92..a12801cb773 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
@@ -141,7 +141,7 @@ export interface SliceHeaderControlsProps {
supersetCanExplore?: boolean;
supersetCanShare?: boolean;
- supersetCanCSV?: boolean;
+ supersetCanDownload?: boolean;
crossFiltersEnabled?: boolean;
}
@@ -519,7 +519,7 @@ const SliceHeaderControls = (
dataSize={20}
isRequest
isVisible
- canDownload={!!props.supersetCanCSV}
+ canDownload={!!props.supersetCanDownload}
columnDisplayNames={datasetWithVerboseMap?.verbose_map}
/>
}
@@ -562,7 +562,7 @@ const SliceHeaderControls = (
newMenuItems.push(shareMenuItems);
}
- if (props.supersetCanCSV) {
+ if (props.supersetCanDownload) {
newMenuItems.push({
type: 'submenu',
key: MenuKeys.Download,
@@ -593,7 +593,7 @@ const SliceHeaderControls = (
icon: <Icons.FileOutlined css={dropdownIconsStyles} />,
},
...(isFeatureEnabled(FeatureFlag.AllowFullCsvExport) &&
- props.supersetCanCSV &&
+ props.supersetCanDownload &&
isTable
? [
{
diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/types.ts b/superset-frontend/src/dashboard/components/SliceHeaderControls/types.ts
index 62d4e94e6bc..cbc285316b4 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls/types.ts
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/types.ts
@@ -57,7 +57,7 @@ export interface SliceHeaderControlsProps {
supersetCanExplore?: boolean;
supersetCanShare?: boolean;
- supersetCanCSV?: boolean;
+ supersetCanDownload?: boolean;
crossFiltersEnabled?: boolean;
}
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx b/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx
index 489ff2adddf..909c7adaddf 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.test.tsx
@@ -89,7 +89,7 @@ const defaultState = {
id: props.dashboardId,
superset_can_explore: false,
superset_can_share: false,
- superset_can_csv: false,
+ superset_can_download: false,
common: { conf: { SUPERSET_WEBSERVER_TIMEOUT: 0, SQL_MAX_ROW: 666 } },
},
dashboardLayout: {
@@ -181,7 +181,10 @@ test('should call exportChart when exportCSV is clicked', async () => {
const { findByText, getByRole } = setup(
{},
{
- dashboardInfo: { ...defaultState.dashboardInfo, superset_can_csv: true },
+ dashboardInfo: {
+ ...defaultState.dashboardInfo,
+ superset_can_download: true,
+ },
},
);
fireEvent.click(getByRole('button', { name: 'More Options' }));
@@ -211,7 +214,10 @@ test('should call exportChart with row_limit props.maxRows when exportFullCSV is
const { findByText, getByRole } = setup(
{},
{
- dashboardInfo: { ...defaultState.dashboardInfo, superset_can_csv: true },
+ dashboardInfo: {
+ ...defaultState.dashboardInfo,
+ superset_can_download: true,
+ },
},
);
fireEvent.click(getByRole('button', { name: 'More Options' }));
@@ -239,7 +245,10 @@ test('should call exportChart when exportXLSX is clicked', async () => {
const { findByText, getByRole } = setup(
{},
{
- dashboardInfo: { ...defaultState.dashboardInfo, superset_can_csv: true },
+ dashboardInfo: {
+ ...defaultState.dashboardInfo,
+ superset_can_download: true,
+ },
},
);
fireEvent.click(getByRole('button', { name: 'More Options' }));
@@ -266,7 +275,10 @@ test('should call exportChart with row_limit props.maxRows when exportFullXLSX i
const { findByText, getByRole } = setup(
{},
{
- dashboardInfo: { ...defaultState.dashboardInfo, superset_can_csv: true },
+ dashboardInfo: {
+ ...defaultState.dashboardInfo,
+ superset_can_download: true,
+ },
},
);
fireEvent.click(getByRole('button', { name: 'More Options' }));
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx b/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx
index a654c56ed1f..5db7bde5337 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx
@@ -218,9 +218,9 @@ const Chart = (props: ChartProps) => {
(state: RootState) =>
!!(state.dashboardInfo as JsonObject).superset_can_share,
);
- const supersetCanCSV = useSelector(
+ const supersetCanDownload = useSelector(
(state: RootState) =>
- !!(state.dashboardInfo as JsonObject).superset_can_csv,
+ !!(state.dashboardInfo as JsonObject).superset_can_download,
);
const timeout: number = useSelector(
(state: RootState) =>
@@ -710,7 +710,7 @@ const Chart = (props: ChartProps) => {
sliceName={props.sliceName}
supersetCanExplore={supersetCanExplore}
supersetCanShare={supersetCanShare}
- supersetCanCSV={supersetCanCSV}
+ supersetCanDownload={supersetCanDownload}
componentId={props.componentId}
dashboardId={props.dashboardId}
filters={getActiveFilters() || EMPTY_OBJECT}