You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:14:14 UTC
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #660: fix: add initContainers to verify if apisix is ready
gxthrj opened a new pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #660: fix: add initContainers to verify if apisix is ready
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660#discussion_r701537246
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -217,7 +217,7 @@ spec:
initContainers:
- name: wait-apisix-admin
image: localhost:5000/busybox:1.28
- command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9080 ; do echo waiting for apisix-admin; sleep 2; done;"]
+ command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9180 ; do echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
Here we add another template `%s`, but it seems you don't change the place we render it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #660: fix: add initContainers to verify if apisix is ready
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660#issuecomment-913063769
Let's go forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #660: fix: add initContainers to verify if apisix is ready
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #660: fix: add initContainers to verify if apisix is ready
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660#discussion_r701599207
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -217,7 +217,7 @@ spec:
initContainers:
- name: wait-apisix-admin
image: localhost:5000/busybox:1.28
- command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9080 ; do echo waiting for apisix-admin; sleep 2; done;"]
+ command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9180 ; do echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
https://github.com/apache/apisix-ingress-controller/pull/660/files#diff-37e06787f8794acb42268c2dde87b4907b54af48e47fdb3b4e2648f97c9fc65aR350 the %s is replaced here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #660: fix: add initContainers to verify if apisix is ready
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660#issuecomment-912228491
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#660](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4daccce) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/75a2aaa979c61aaeab9b5412b937a618d1f56bca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75a2aaa) will **increase** coverage by `0.04%`.
> The diff coverage is `45.83%`.
> :exclamation: Current head 4daccce differs from pull request most recent head da4598d. Consider uploading reports for the commit da4598d to get more accurate results
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 34.72% 34.77% +0.04%
==========================================
Files 60 60
Lines 5892 5916 +24
==========================================
+ Hits 2046 2057 +11
- Misses 3596 3608 +12
- Partials 250 251 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `42.42% <0.00%> (-2.03%)` | :arrow_down: |
| [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `26.57% <41.66%> (+0.41%)` | :arrow_up: |
| [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `63.26% <100.00%> (+5.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d4a832c...da4598d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/660?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #660: fix: add initContainers to verify if apisix is ready
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660#discussion_r700971230
##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -750,6 +750,10 @@ spec:
items:
- key: config.yaml
path: config.yaml
+ initContainers:
+ - name: wait-apisix-admin
+ image: busybox:1.28
+ command: ['sh', '-c', "until nc -z apisix-service.apisix.svc.cluster.local 9080 ; do echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
Its port is `9180`.
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -214,6 +214,10 @@ spec:
app: ingress-apisix-controller-deployment-e2e-test
spec:
terminationGracePeriodSeconds: 0
+ initContainers:
+ - name: wait-apisix-admin
+ image: localhost:5000/busybox:1.28
+ command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9080 ; do echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
Ditto, admin port is `9180`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #660: fix: add initContainers to verify if apisix is ready
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #660:
URL: https://github.com/apache/apisix-ingress-controller/pull/660#discussion_r701735253
##########
File path: Makefile
##########
@@ -104,6 +104,10 @@ ifeq ($(E2E_SKIP_BUILD), 0)
docker pull jmalloc/echo-server:latest
docker tag jmalloc/echo-server:latest $(LOCAL_REGISTRY)/jmalloc/echo-server:latest
docker push $(LOCAL_REGISTRY)/jmalloc/echo-server:latest
+
+ docker pull busybox:1.28
+ docker tag busybox:1.28 $(LOCAL_REGISTRY)/busybox:1.28
+ docker push $(LOCAL_REGISTRY)/busybox:1.28
Review comment:
Please don't forget to modify helm chart.
##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -217,7 +217,7 @@ spec:
initContainers:
- name: wait-apisix-admin
image: localhost:5000/busybox:1.28
- command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9080 ; do echo waiting for apisix-admin; sleep 2; done;"]
+ command: ['sh', '-c', "until nc -z apisix-service-e2e-test.%s.svc.cluster.local 9180 ; do echo waiting for apisix-admin; sleep 2; done;"]
Review comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org