You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "diaohancai (via GitHub)" <gi...@apache.org> on 2024/01/01 09:11:29 UTC

[PR] improve(algorithm): random walk vertex inactive [incubator-hugegraph-computer]

diaohancai opened a new pull request, #301:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/301

   ## Purpose of the PR
   
   - improve random walk algorithm 
   
   ## Main Changes
   
   
   ## Verifying these changes
   
   - [X] Trivial rework / code cleanup without any test coverage. (No Need)
   - [ ] Already covered by existing tests, such as *(please modify tests here)*.
   - [ ] Need tests and can be verified as follows.
   
   ## Does this PR potentially affect the following parts?
   - [X]  Nope
   - [ ]  Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
   - [ ]  Modify configurations
   - [ ]  The public API
   - [ ]  Other affects (typed here)
   
   ## Documentation Status
   
   - [ ]  `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
   - [ ]  `Doc - Done` <!-- Related docs have been already added or updated -->
   - [X]  `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] improve(algorithm): random walk vertex inactive [incubator-hugegraph-computer]

Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on PR #301:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/301#issuecomment-1890341235

   Note the CI failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] improve(algorithm): random walk vertex inactive [incubator-hugegraph-computer]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #301:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/301#issuecomment-1873242144

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `34 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`e0b484a`)](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/commit/e0b484a65e2244ec49ef8bbc14185acd99dbc436?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 85.03% compared to head [(`a793509`)](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 85.17%.
   > Report is 6 commits behind head on master.
   
   | [Files](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...apache/hugegraph/computer/core/bsp/EtcdClient.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvYnNwL0V0Y2RDbGllbnQuamF2YQ==) | 52.38% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hugegraph/computer/core/worker/WorkerService.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvd29ya2VyL1dvcmtlclNlcnZpY2UuamF2YQ==) | 85.93% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../hugegraph/computer/core/master/MasterService.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvbWFzdGVyL01hc3RlclNlcnZpY2UuamF2YQ==) | 50.00% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...hugegraph/computer/core/util/StringEncodeUtil.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvdXRpbC9TdHJpbmdFbmNvZGVVdGlsLmphdmE=) | 54.54% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...raph/computer/k8s/operator/OperatorEntrypoint.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItazhzLW9wZXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWdlZ3JhcGgvY29tcHV0ZXIvazhzL29wZXJhdG9yL09wZXJhdG9yRW50cnlwb2ludC5qYXZh) | 81.81% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...h/computer/core/network/session/ClientSession.java](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2NvbXB1dGVyL2NvcmUvbmV0d29yay9zZXNzaW9uL0NsaWVudFNlc3Npb24uamF2YQ==) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #301      +/-   ##
   ============================================
   + Coverage     85.03%   85.17%   +0.14%     
   - Complexity     3296     3300       +4     
   ============================================
     Files           349      349              
     Lines         12485    12461      -24     
     Branches       1130     1123       -7     
   ============================================
   - Hits          10616    10614       -2     
   + Misses         1329     1307      -22     
     Partials        540      540              
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] improve(algorithm): random walk vertex inactive [incubator-hugegraph-computer]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #301:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org