[GitHub] [flink] klion26 commented on a change in pull request #13045: [FLINK-18748][checkpointing] trigger unperiodic checkpoint immediately

[GitBox <gi...@apache.org>]

klion26 commented on a change in pull request #13045:
URL: https://github.com/apache/flink/pull/13045#discussion_r464197260



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointRequestDecider.java
##########
@@ -136,6 +136,11 @@
 				.map(unused -> queuedRequests.pollFirst());
 		}
 
+		CheckpointTriggerRequest first = queuedRequests.first();

Review comment:
       maybe we can reuse the `first` in `onTooEarly` function

##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointRequestDeciderTest.java
##########
@@ -119,13 +119,13 @@ public void testQueueSizeLimitPriority() {
 	public void testSavepointTiming() {
 		testTiming(regularSavepoint(), TriggerExpectation.IMMEDIATELY);
 		testTiming(periodicSavepoint(), TriggerExpectation.IMMEDIATELY);
-		testTiming(nonForcedSavepoint(), TriggerExpectation.AFTER_PAUSE);
+		testTiming(nonForcedSavepoint(), TriggerExpectation.IMMEDIATELY);

Review comment:
       after this change, do we need to add a test to guarantee "savepoint and checkpoint would not execute concurrently under unaligned checkpoint mode"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org