[jira] [Commented] (MPATCH-19) ignored patches must not be applied

["Matthias Balke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPATCH-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386149#comment-16386149 ] 

Matthias Balke commented on MPATCH-19:
--------------------------------------

It seems, that I'm searching for an {{exludePattern}} configuration, which is not available yet. The {{ignorePatches}} option is just very misleading. The documentation should be updated to explain, that this will not exlude patches found in {{patchDirectory}}.

 

I'll file a feature request and provide a PR for the excludePattern support.

> ignored patches must not be applied
> -----------------------------------
>
>                 Key: MPATCH-19
>                 URL: https://issues.apache.org/jira/browse/MPATCH-19
>             Project: Maven Patch Plugin
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Matthias Balke
>            Priority: Critical
>
> To reproduce this bug one has to configure the maven patch plugin to ignore some patches.
> {code:java}
> <ignoredPatches>
>     <ignoredPatch>ignored.patch</ignoredPatch>
> </ignoredPatches>{code}
> When executing the plugin the ignored files are also applied! It seems that this feature is broken or not well enough documented.
> Also using {{strictPatching}} does not work as documented:
> {code:java}
> <strictPatching>true</strictPatching>
> <ignoredPatches>
>     <ignoredPatch>ignored.patch</ignoredPatch>
> </ignoredPatches>{code}
> I created a minimal example to reproduce this bug: https://github.com/matthiasbalke/maven-patch-plugin-MPATCH-19



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)