You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/05 01:23:24 UTC
[GitHub] [tvm] jsheng-jian opened a new pull request, #11579: [Runtime] Add runtime.contrib.set_custom_cpu_allocator to use custom memalign() and free() functions
jsheng-jian opened a new pull request, #11579:
URL: https://github.com/apache/tvm/pull/11579
This PR adds a new function runtime.contrib.set_custom_cpu_allocator to the registry which can be used to override the memalign() and free() functions used by CPUDeviceAPI.
Upstream original [PR](https://github.com/neo-ai/tvm/pull/141) by @trevor-m .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #11579: [Runtime] Add runtime.contrib.set_custom_cpu_allocator to use custom memalign() and free() functions
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11579:
URL: https://github.com/apache/tvm/pull/11579#issuecomment-1202980779
Having an extra null pointer check is not going to be significantly affect performance, but I would be curious on the implication of user-facing API.
There could be some compile-time alternatives, for example, using macros to control which `alloc`/`free` methods to use. Do you think it's viable in your usecase?
Thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #11579: [Runtime] Add runtime.contrib.set_custom_cpu_allocator to use custom memalign() and free() functions
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11579:
URL: https://github.com/apache/tvm/pull/11579#issuecomment-1149047024
@jsheng-jian thanks for the PR! i think this maybe deserves a broader look by the community as it could potentially impact performance. just curious, did you consider a compile-time workaround here as well? would that work for your use case, or does it need to always be available?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Runtime] Add runtime.contrib.set_custom_cpu_allocator to use custom memalign() and free() functions [tvm]
Posted by "jsheng-jian (via GitHub)" <gi...@apache.org>.
jsheng-jian closed pull request #11579: [Runtime] Add runtime.contrib.set_custom_cpu_allocator to use custom memalign() and free() functions
URL: https://github.com/apache/tvm/pull/11579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #11579: [Runtime] Add runtime.contrib.set_custom_cpu_allocator to use custom memalign() and free() functions
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11579:
URL: https://github.com/apache/tvm/pull/11579#issuecomment-1149048514
cc @tqchen @csullivan @junrushao1994 @
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #11579: [Runtime] Add runtime.contrib.set_custom_cpu_allocator to use custom memalign() and free() functions
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #11579:
URL: https://github.com/apache/tvm/pull/11579#issuecomment-1211437719
@jsheng-jian could you address the question above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org