You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2005/01/12 05:40:28 UTC
[jira] Created: (MPANT-23) Add License file to jar META-INF
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANT-23
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANT-23
Summary: Add License file to jar META-INF
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-ant-plugin
Assignee: Arnaud HERITIER
Reporter: Phil Steitz
Created: Tue, 11 Jan 2005 11:39 PM
Updated: Tue, 11 Jan 2005 11:39 PM
Description:
The maven jar plugin automatically adds license files to jar META-INF. The Ant plugin can be made to generate a build.xml that does this by including this file as a resource with targetpath META-INF, but this causes the maven jar task to insert two copies of the file.
It would be great if the ant plugin generated a build.xml that does the same thing that the maven jar task does. I am attaching a patch that works if the url property of licenses in the POM is a relative local path reference to the license file. I could not figure out how to canonicalize the file path as the jar plugin appears to do.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPANT-23) Add License file to jar META-INF
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Sun, 16 Jan 2005 6:46 PM
Body:
Hmmm...
the license/url element is not supposed to be used for a file in this way AFAIK.
The jar plugin does this:
<j:set var="licenseFileName"><license:fileName/></j:set>
<util:file name="${licenseFileName}" var="licenseFile"/>
<ant:metainf dir="${licenseFile.canonicalFile.parent}">
<ant:include name="${licenseFile.canonicalFile.name}"/>
</ant:metainf>
Which uses ${maven.license.licenseFile} and defaults to ${basedir}/LICENSE.txt.
We could use the <license:relativeFileName /> tag to get the license file relative to ${basedir} for the Ant plugin.
Whaddya think?
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPANT-23?page=comments#action_28996
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANT-23
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANT-23
Summary: Add License file to jar META-INF
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-ant-plugin
Assignee: Arnaud HERITIER
Reporter: Phil Steitz
Created: Tue, 11 Jan 2005 11:39 PM
Updated: Sun, 16 Jan 2005 6:46 PM
Description:
The maven jar plugin automatically adds license files to jar META-INF. The Ant plugin can be made to generate a build.xml that does this by including this file as a resource with targetpath META-INF, but this causes the maven jar task to insert two copies of the file.
It would be great if the ant plugin generated a build.xml that does the same thing that the maven jar task does. I am attaching a patch that works if the url property of licenses in the POM is a relative local path reference to the license file. I could not figure out how to canonicalize the file path as the jar plugin appears to do.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPANT-23) Add License file to jar META-INF
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Phil Steitz (mailto:phil@steitz.com)
Date: Mon, 17 Jan 2005 1:45 AM
Comment:
This patch use maven.license.licenseFile to locate the license file. It should be improved to somehow handle the case where there is no license file, since if nothing is specified it will default to ${basedir}/LICENSE.txt and add a copy directive for that, which will cause the ant build to fail.
Changes:
Attachment changed to antPlugin2.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPANT-23?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANT-23
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANT-23
Summary: Add License file to jar META-INF
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-ant-plugin
Assignee: Arnaud HERITIER
Reporter: Phil Steitz
Created: Tue, 11 Jan 2005 11:39 PM
Updated: Mon, 17 Jan 2005 1:45 AM
Description:
The maven jar plugin automatically adds license files to jar META-INF. The Ant plugin can be made to generate a build.xml that does this by including this file as a resource with targetpath META-INF, but this causes the maven jar task to insert two copies of the file.
It would be great if the ant plugin generated a build.xml that does the same thing that the maven jar task does. I am attaching a patch that works if the url property of licenses in the POM is a relative local path reference to the license file. I could not figure out how to canonicalize the file path as the jar plugin appears to do.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPANT-23) Add License file to jar META-INF
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Phil Steitz (mailto:phil@steitz.com)
Date: Tue, 11 Jan 2005 11:40 PM
Changes:
Attachment changed to antPluginPatch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPANT-23?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANT-23
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANT-23
Summary: Add License file to jar META-INF
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-ant-plugin
Assignee: Arnaud HERITIER
Reporter: Phil Steitz
Created: Tue, 11 Jan 2005 11:39 PM
Updated: Tue, 11 Jan 2005 11:40 PM
Description:
The maven jar plugin automatically adds license files to jar META-INF. The Ant plugin can be made to generate a build.xml that does this by including this file as a resource with targetpath META-INF, but this causes the maven jar task to insert two copies of the file.
It would be great if the ant plugin generated a build.xml that does the same thing that the maven jar task does. I am attaching a patch that works if the url property of licenses in the POM is a relative local path reference to the license file. I could not figure out how to canonicalize the file path as the jar plugin appears to do.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPANT-23) Add License file to jar META-INF
Posted by ji...@codehaus.org.
Message:
The following issue has been closed.
Resolver: Arnaud HERITIER
Date: Sat, 26 Feb 2005 8:53 PM
Applied. thanks
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANT-23
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANT-23
Summary: Add License file to jar META-INF
Type: Improvement
Status: Closed
Priority: Minor
Resolution: FIXED
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-ant-plugin
Fix Fors:
1.9
Assignee: Arnaud HERITIER
Reporter: Phil Steitz
Created: Tue, 11 Jan 2005 11:39 PM
Updated: Sat, 26 Feb 2005 8:53 PM
Description:
The maven jar plugin automatically adds license files to jar META-INF. The Ant plugin can be made to generate a build.xml that does this by including this file as a resource with targetpath META-INF, but this causes the maven jar task to insert two copies of the file.
It would be great if the ant plugin generated a build.xml that does the same thing that the maven jar task does. I am attaching a patch that works if the url property of licenses in the POM is a relative local path reference to the license file. I could not figure out how to canonicalize the file path as the jar plugin appears to do.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPANT-23) Add License file to jar META-INF
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Phil Steitz
Created: Sun, 16 Jan 2005 9:11 PM
Body:
Defintely looks better. I did not know of maven.license.licenseFile and was incorrectly thinking that it was related to the licenses element in the POM.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPANT-23?page=comments#action_29002
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANT-23
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANT-23
Summary: Add License file to jar META-INF
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-ant-plugin
Assignee: Arnaud HERITIER
Reporter: Phil Steitz
Created: Tue, 11 Jan 2005 11:39 PM
Updated: Sun, 16 Jan 2005 9:11 PM
Description:
The maven jar plugin automatically adds license files to jar META-INF. The Ant plugin can be made to generate a build.xml that does this by including this file as a resource with targetpath META-INF, but this causes the maven jar task to insert two copies of the file.
It would be great if the ant plugin generated a build.xml that does the same thing that the maven jar task does. I am attaching a patch that works if the url property of licenses in the POM is a relative local path reference to the license file. I could not figure out how to canonicalize the file path as the jar plugin appears to do.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org