[GitHub] [fluo-muchos] keith-turner commented on pull request #356: Normalize hdfs-site.xml across HA and non-HA cases

[GitBox <gi...@apache.org>]

keith-turner commented on pull request #356:
URL: https://github.com/apache/fluo-muchos/pull/356#issuecomment-657925204


   > This change allows using the nameservice_id as a stable and simple way to reference namenodes regardless of whether HA is used / or not
   
   @arvindshmicrosoft with this change would it be ok to always use the nameservice id for `hdfs_root`?  I looked around for where it was set and found the following in `./lib/muchos/config/base.py`.
   
   ```
       "hdfs_root": (
           "{% if hdfs_ha %}hdfs://{{ nameservice_id }}{% else %}"
           "hdfs://{{ groups['namenode'][0] }}:8020{% endif %}"
       ),
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org