You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Ramkumar Vadali (JIRA)" <ji...@apache.org> on 2010/10/21 00:18:24 UTC

[jira] Created: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Refactor DFSck to allow programmatic access to output
-----------------------------------------------------

                 Key: HDFS-1472
                 URL: https://issues.apache.org/jira/browse/HDFS-1472
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: tools
            Reporter: Ramkumar Vadali


DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur updated HDFS-1472:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks Ram!

> Refactor DFSck to allow programmatic access to output
> -----------------------------------------------------
>
>                 Key: HDFS-1472
>                 URL: https://issues.apache.org/jira/browse/HDFS-1472
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Ramkumar Vadali
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1472.patch
>
>
> DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramkumar Vadali updated HDFS-1472:
----------------------------------

    Attachment: HDFS-1472.patch

Adds a constructor DFSck(Configuration, PrintStream). This is better than modifying System.out.

> Refactor DFSck to allow programmatic access to output
> -----------------------------------------------------
>
>                 Key: HDFS-1472
>                 URL: https://issues.apache.org/jira/browse/HDFS-1472
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Ramkumar Vadali
>         Attachments: HDFS-1472.patch
>
>
> DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924067#action_12924067 ] 

Ramkumar Vadali commented on HDFS-1472:
---------------------------------------

Test results:

ant test-patch:


     [exec]
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to i
     [exec] nclude 2 new or modified tests.
     [exec]     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec]
     [exec]     +1 system tests framework.  The patch passed system tests framework compile.
     [exec]     [exec]
     [exec]
     [exec]
     [exec] ======================================================================
     [exec] ======================================================================
     [exec]     Finished build.
     [exec] ======================================================================
     [exec] ======================================================================

ant test:
Some tests failed, but I verified that these fail in a clean checkout as well.
    [junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery FAILED
    [junit] Test org.apache.hadoop.hdfs.TestFileStatus FAILED
    [junit] Test org.apache.hadoop.hdfs.TestHDFSTrash FAILED (timeout)
    [junit] Test org.apache.hadoop.fs.TestHDFSFileContextMainOperations FAILED
    [junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery FAILED


> Refactor DFSck to allow programmatic access to output
> -----------------------------------------------------
>
>                 Key: HDFS-1472
>                 URL: https://issues.apache.org/jira/browse/HDFS-1472
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Ramkumar Vadali
>         Attachments: HDFS-1472.patch
>
>
> DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924117#action_12924117 ] 

Hadoop QA commented on HDFS-1472:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12457711/HDFS-1472.patch
  against trunk revision 1026178.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system tests framework.  The patch passed system tests framework compile.

Test results: http://hudson.zones.apache.org/hudson/job/PreCommit-HDFS-Build/2/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/PreCommit-HDFS-Build/2/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/PreCommit-HDFS-Build/2/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/PreCommit-HDFS-Build/2/console

This message is automatically generated.

> Refactor DFSck to allow programmatic access to output
> -----------------------------------------------------
>
>                 Key: HDFS-1472
>                 URL: https://issues.apache.org/jira/browse/HDFS-1472
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Ramkumar Vadali
>         Attachments: HDFS-1472.patch
>
>
> DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ramkumar Vadali updated HDFS-1472:
----------------------------------

    Status: Patch Available  (was: Open)

> Refactor DFSck to allow programmatic access to output
> -----------------------------------------------------
>
>                 Key: HDFS-1472
>                 URL: https://issues.apache.org/jira/browse/HDFS-1472
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Ramkumar Vadali
>         Attachments: HDFS-1472.patch
>
>
> DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924289#action_12924289 ] 

Hudson commented on HDFS-1472:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #416 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/416/])
    HDFS-1472. Allow programmatic access to fsck output.
(Ramkumar Vadali via dhruba)


> Refactor DFSck to allow programmatic access to output
> -----------------------------------------------------
>
>                 Key: HDFS-1472
>                 URL: https://issues.apache.org/jira/browse/HDFS-1472
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Ramkumar Vadali
>            Assignee: Ramkumar Vadali
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1472.patch
>
>
> DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HDFS-1472) Refactor DFSck to allow programmatic access to output

Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dhruba borthakur reassigned HDFS-1472:
--------------------------------------

    Assignee: Ramkumar Vadali

> Refactor DFSck to allow programmatic access to output
> -----------------------------------------------------
>
>                 Key: HDFS-1472
>                 URL: https://issues.apache.org/jira/browse/HDFS-1472
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Ramkumar Vadali
>            Assignee: Ramkumar Vadali
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1472.patch
>
>
> DFSck prints the list of corrupt files to stdout. This jira proposes that it write to a PrintStream object that is passed to the constructor. This will allow components like RAID to programmatically get a list of corrupt files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.