You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/06 23:38:35 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #17480: Ask for provider versions in bug reports
jedcunningham opened a new pull request #17480:
URL: https://github.com/apache/airflow/pull/17480
We get a lot of bug reports for providers, and it's rare that the
versions being used are in the initial report. Let's ask for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17480: Ask for provider versions in bug reports
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17480:
URL: https://github.com/apache/airflow/pull/17480#discussion_r684605982
##########
File path: .github/ISSUE_TEMPLATE/bug_report.md
##########
@@ -36,6 +36,13 @@ These questions are the first thing we need to know to understand the context.
**Apache Airflow version**:
+**Apache Airflow Provider versions** (please include all providers that are relevant to your bug):
+
Review comment:
Actually better advice will be 'airflow providers list' command output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17480: Ask for provider versions in bug reports
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17480:
URL: https://github.com/apache/airflow/pull/17480#discussion_r684713956
##########
File path: .github/ISSUE_TEMPLATE/bug_report.md
##########
@@ -36,6 +36,13 @@ These questions are the first thing we need to know to understand the context.
**Apache Airflow version**:
+**Apache Airflow Provider versions** (please include all providers that are relevant to your bug):
+
Review comment:
TIL. That said, I think I prefer the output from pip as it doesn't have the description (assuming folks will copy/paste most likely). Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17480: Ask for provider versions in bug reports
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17480:
URL: https://github.com/apache/airflow/pull/17480#issuecomment-894604023
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17480: Ask for provider versions in bug reports
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17480:
URL: https://github.com/apache/airflow/pull/17480#discussion_r684715263
##########
File path: .github/ISSUE_TEMPLATE/bug_report.md
##########
@@ -36,6 +36,13 @@ These questions are the first thing we need to know to understand the context.
**Apache Airflow version**:
+**Apache Airflow Provider versions** (please include all providers that are relevant to your bug):
+
Review comment:
The one difference is that providers list might contain more than community providers. Those are all registered ones which is discovered by scanning the entrypoints.
For issues in community we indeed care more about the community ones though. So i think both are fine and agree that description is not really needed in this case so `pip freeze` will do its job well.
One other difference that airflow providers works also when you use INSTALL_PROVIDERS_FROM_SOURCES flag and providers are discovered from local sources rather than from packages (but this is not our case here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17480: Ask for provider versions in bug reports
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17480:
URL: https://github.com/apache/airflow/pull/17480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org