You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/09 21:21:21 UTC
[GitHub] [hbase] clarax opened a new pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
clarax opened a new pull request #2376:
URL: https://github.com/apache/hbase/pull/2376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r486465824
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
How about inverting the logic, only log the functions loaded, rather than those skipped, and please make it a `DEBUG` level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691260734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
@clarax we should raise PR against master branch for changes which are not branch specific. branch-2, 2.3 gets the backports anyways.
Maybe you can wait till this PR gets approval and then raise master branch PR which can be used for all backports.
Nice find!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
clarax commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r486495740
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
This only gets logged once when the config is first loaded or updated.The function loaded is already reported at https://github.com/apache/hbase/blob/9e017e261ed323c25e9c36c36f8ee628e855830a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java#L224
I can change this into debug mode since the summary is already reported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-689852176
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 54s | branch-2.3 passed |
| +1 :green_heart: | checkstyle | 1m 6s | branch-2.3 passed |
| +1 :green_heart: | spotbugs | 2m 2s | branch-2.3 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 19s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 13s | the patch passed |
| -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | hadoopcheck | 17m 23s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
| | | 39m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux f3fa290086e6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / 72d0cdd9fd |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-724864265
@clarax This PR is closed because #2386 has already been committed to master, branch-2, branch-2.3 and branch-1.
e.g master branch commit: https://github.com/apache/hbase/commit/fe776306d09b1e37551a3ccfef800a720866963f
Similarly, you can find rest of commits at the end of PR #2386 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] clarax commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
clarax commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-724847545
@virajjasani Is there reason this is not merged before being closed? Could you please reopen and merge?
the same for https://github.com/apache/hbase/pull/2386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r486791208
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] clarax commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
clarax commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r486496254
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -204,19 +204,19 @@ public synchronized void setConf(Configuration conf) {
regionReplicaRackCostFunction = new RegionReplicaRackCostFunction(conf);
costFunctions = new ArrayList<>();
- costFunctions.add(new RegionCountSkewCostFunction(conf));
- costFunctions.add(new PrimaryRegionCountSkewCostFunction(conf));
- costFunctions.add(new MoveCostFunction(conf));
- costFunctions.add(localityCost);
- costFunctions.add(rackLocalityCost);
- costFunctions.add(new TableSkewCostFunction(conf));
- costFunctions.add(regionReplicaHostCostFunction);
- costFunctions.add(regionReplicaRackCostFunction);
- costFunctions.add(regionLoadFunctions[0]);
- costFunctions.add(regionLoadFunctions[1]);
- costFunctions.add(regionLoadFunctions[2]);
- costFunctions.add(regionLoadFunctions[3]);
- loadCustomCostFunctions(conf);
Review comment:
Goo catch. Thank you.Will add back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r487217554
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
@clarax we should raise PR against master branch for changes which are not branch specific. branch-2, 2.3 gets the backports anyways.
Maybe you can wait till this PR gets approval and then raise master branch PR which can be used for all backports.
Nice find btw!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] clarax commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
clarax commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691243060
https://github.com/apache/hbase/pull/2386 for master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-689923353
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 31s | branch-2.3 passed |
| +1 :green_heart: | compile | 1m 57s | branch-2.3 passed |
| +1 :green_heart: | shadedjars | 10m 29s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 1m 5s | hbase-server in branch-2.3 failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 21s | the patch passed |
| +1 :green_heart: | javac | 1m 21s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 31s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 45s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 194m 28s | hbase-server in the patch failed. |
| | | 232m 38s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 23c7584f5a72 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / 72d0cdd9fd |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/testReport/ |
| Max. process+thread count | 3332 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690791405
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 39s | branch-2.3 passed |
| +1 :green_heart: | compile | 0m 54s | branch-2.3 passed |
| +1 :green_heart: | shadedjars | 5m 2s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | branch-2.3 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 17s | the patch passed |
| +1 :green_heart: | compile | 0m 53s | the patch passed |
| +1 :green_heart: | javac | 0m 53s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 133m 21s | hbase-server in the patch passed. |
| | | 156m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 5c631d0727d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / 1c494bb8d8 |
| Default Java | 1.8.0_232 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/testReport/ |
| Max. process+thread count | 3975 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r486791208
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691260734
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 15s | branch-2.3 passed |
| +1 :green_heart: | checkstyle | 1m 8s | branch-2.3 passed |
| +1 :green_heart: | spotbugs | 1m 58s | branch-2.3 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 12s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 5s | the patch passed |
| -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | hadoopcheck | 16m 57s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 6s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 37m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux d4c11c851f1f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / f38292307c |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r487186272
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
@clarax can you raise PR for master branch? branch-2, 2.3 will get the backports anyways.
Maybe you can wait till this PR gets approval and then raise master branch PR which can be used for all backports.
Nice find!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-689893663
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 39s | branch-2.3 passed |
| +1 :green_heart: | compile | 0m 57s | branch-2.3 passed |
| +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | branch-2.3 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 11s | the patch passed |
| +1 :green_heart: | compile | 0m 54s | the patch passed |
| +1 :green_heart: | javac | 0m 54s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 133m 28s | hbase-server in the patch failed. |
| | | 156m 7s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux d45574d9c661 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / 72d0cdd9fd |
| Default Java | 1.8.0_232 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/testReport/ |
| Max. process+thread count | 4230 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani closed pull request #2376:
URL: https://github.com/apache/hbase/pull/2376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
huaxiangsun commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r485986268
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -204,19 +204,19 @@ public synchronized void setConf(Configuration conf) {
regionReplicaRackCostFunction = new RegionReplicaRackCostFunction(conf);
costFunctions = new ArrayList<>();
- costFunctions.add(new RegionCountSkewCostFunction(conf));
- costFunctions.add(new PrimaryRegionCountSkewCostFunction(conf));
- costFunctions.add(new MoveCostFunction(conf));
- costFunctions.add(localityCost);
- costFunctions.add(rackLocalityCost);
- costFunctions.add(new TableSkewCostFunction(conf));
- costFunctions.add(regionReplicaHostCostFunction);
- costFunctions.add(regionReplicaRackCostFunction);
- costFunctions.add(regionLoadFunctions[0]);
- costFunctions.add(regionLoadFunctions[1]);
- costFunctions.add(regionLoadFunctions[2]);
- costFunctions.add(regionLoadFunctions[3]);
- loadCustomCostFunctions(conf);
Review comment:
Why is this removed in the patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r486791208
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
I believe it's better to have this logic:
```
if (costFunction.getMultiplier() > 0) {
LOG.debug("Including cost function {}", costFunction.getClass().getSimpleName());
costFunctions.add(costFunction);
}
```
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Seems changes are incorporated here https://github.com/apache/hbase/pull/2386
@ndimiduk @huaxiangsun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r487186272
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691309108
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 16s | branch-2.3 passed |
| +1 :green_heart: | compile | 1m 2s | branch-2.3 passed |
| +1 :green_heart: | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2.3 failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 47s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 131m 47s | hbase-server in the patch passed. |
| | | 158m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 96daff3a231d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / f38292307c |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/testReport/ |
| Max. process+thread count | 3888 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690791595
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 2s | Docker mode activated. |
| -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 20s | branch-2.3 passed |
| +1 :green_heart: | compile | 1m 3s | branch-2.3 passed |
| +1 :green_heart: | shadedjars | 5m 52s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2.3 failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 3s | the patch passed |
| +1 :green_heart: | javac | 1m 3s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 46s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 42s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 127m 15s | hbase-server in the patch passed. |
| | | 156m 56s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 68dfe121b882 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / 1c494bb8d8 |
| Default Java | 2020-01-14 |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/testReport/ |
| Max. process+thread count | 4017 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690895741
@clarax we should raise PR against master branch for changes which are not branch specific. branch-2, 2.3 gets the backports anyways.
Maybe you can wait till this PR gets approval and then raise master branch PR which can be used for all backports.
Nice find to save quite some computation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r487186272
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
@clarax Oh, right. Since there's already a summary log at info that lists out all the loaded functions, I'd say omit the debug logging entirely. You good with that plan @virajjasani ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#discussion_r487216767
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -596,6 +596,14 @@ protected void updateCostsWithAction(Cluster cluster, Action action) {
}
}
+ private void addCostFunction(CostFunction costFunction) {
+ if (costFunction.getMultiplier() <= 0) {
+ LOG.info("exclude cost function {}", costFunction.getClass().getSimpleName());
Review comment:
Yeah, sounds better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] clarax commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
clarax commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691243060
https://github.com/apache/hbase/pull/2386 for master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-690752940
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 40s | branch-2.3 passed |
| +1 :green_heart: | checkstyle | 1m 9s | branch-2.3 passed |
| +1 :green_heart: | spotbugs | 1m 59s | branch-2.3 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 14s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 7s | the patch passed |
| -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | hadoopcheck | 16m 53s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 2m 3s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 38m 19s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 765f43c47545 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / 1c494bb8d8 |
| whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/artifact/yetus-general-check/output/whitespace-eol.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691260734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691311977
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 40s | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 26s | branch-2.3 passed |
| +1 :green_heart: | compile | 0m 57s | branch-2.3 passed |
| +1 :green_heart: | shadedjars | 5m 12s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | branch-2.3 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 32s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 23s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 141m 57s | hbase-server in the patch passed. |
| | | 165m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2376 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c5df02dd3190 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.3 / f38292307c |
| Default Java | 1.8.0_232 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/testReport/ |
| Max. process+thread count | 3733 (vs. ulimit of 12500) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2376/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] clarax commented on pull request #2376: HBASE-25006 Make the cost functions optional for StochastoicBalancer
Posted by GitBox <gi...@apache.org>.
clarax commented on pull request #2376:
URL: https://github.com/apache/hbase/pull/2376#issuecomment-691243060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org