You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/18 15:08:18 UTC

[GitHub] [shardingsphere] sluk3r opened a new pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

sluk3r opened a new pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517


   Fixes #7285.
   
   Changes proposed in this pull request:
   - AbstractBootstrapInitializerTest refactored to extension for both of StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest
   -
   -
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517#issuecomment-695192204


   ## Pull Request Test Coverage Report for [Build 14915](https://coveralls.io/builds/33586308)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **35.081%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33586308/badge)](https://coveralls.io/builds/33586308) |
   | :-- | --: |
   | Change from base [Build 14912](https://coveralls.io/builds/33581543): |  0.0% |
   | Covered Lines: | 36576 |
   | Relevant Lines: | 104263 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517#discussion_r491437232



##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/pom.xml
##########
@@ -88,6 +88,13 @@
             <artifactId>shardingsphere-tracing-opentracing</artifactId>
             <version>${project.version}</version>
         </dependency>
+
+        <dependency>
+            <groupId>org.apache.commons</groupId>
+            <artifactId>commons-lang3</artifactId>
+            <version>3.10</version>
+            <scope>test</scope>
+        </dependency>

Review comment:
       Please do not add dependency for test only.
   It is better to discuss of adding new dependency before do it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517#issuecomment-695192204


   ## Pull Request Test Coverage Report for [Build 14908](https://coveralls.io/builds/33579176)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **35.083%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33579176/badge)](https://coveralls.io/builds/33579176) |
   | :-- | --: |
   | Change from base [Build 14906](https://coveralls.io/builds/33569554): |  0.0% |
   | Covered Lines: | 36580 |
   | Relevant Lines: | 104268 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517#issuecomment-695192204


   ## Pull Request Test Coverage Report for [Build 14914](https://coveralls.io/builds/33586201)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **35.081%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33586201/badge)](https://coveralls.io/builds/33586201) |
   | :-- | --: |
   | Change from base [Build 14912](https://coveralls.io/builds/33581543): |  0.0% |
   | Covered Lines: | 36576 |
   | Relevant Lines: | 104263 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517#issuecomment-695192204


   ## Pull Request Test Coverage Report for [Build 14913](https://coveralls.io/builds/33586083)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **14** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.002%**) to **35.081%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/TextProtocolBackendHandlerFactory.java](https://coveralls.io/builds/33586083/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Ftext%2FTextProtocolBackendHandlerFactory.java#L65) | 1 | 92.31% |
   | [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/text/query/MySQLComQueryPacketExecutor.java](https://coveralls.io/builds/33586083/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Ftext%2Fquery%2FMySQLComQueryPacketExecutor.java#L44) | 4 | 75.0% |
   | [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/binary/execute/MySQLComStmtExecuteExecutor.java](https://coveralls.io/builds/33586083/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Fbinary%2Fexecute%2FMySQLComStmtExecuteExecutor.java#L49) | 9 | 60.87% |
   <!-- | **Total:** | **14** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33586083/badge)](https://coveralls.io/builds/33586083) |
   | :-- | --: |
   | Change from base [Build 14906](https://coveralls.io/builds/33569554): |  -0.002% |
   | Covered Lines: | 36576 |
   | Relevant Lines: | 104263 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sluk3r commented on a change in pull request #7517: Add abstract class of AbstractBootstrapInitializerTest which is extended by StandardBootstrapInitializerTest and GovernanceBootstrapInitializerTest

Posted by GitBox <gi...@apache.org>.
sluk3r commented on a change in pull request #7517:
URL: https://github.com/apache/shardingsphere/pull/7517#discussion_r491666349



##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/pom.xml
##########
@@ -88,6 +88,13 @@
             <artifactId>shardingsphere-tracing-opentracing</artifactId>
             <version>${project.version}</version>
         </dependency>
+
+        <dependency>
+            <groupId>org.apache.commons</groupId>
+            <artifactId>commons-lang3</artifactId>
+            <version>3.10</version>
+            <scope>test</scope>
+        </dependency>

Review comment:
       removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org