You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Chuan Liu (JIRA)" <ji...@apache.org> on 2013/06/04 07:08:20 UTC
[jira] [Updated] (HADOOP-9609) Remove sh dependency of bin-package
target
[ https://issues.apache.org/jira/browse/HADOOP-9609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chuan Liu updated HADOOP-9609:
------------------------------
Attachment: HADOOP-9609-branch-1-win-2.patch
Thanks for reviewing the patch! I did notice the difference between packageNativeHadoop and packageBinNativeHadoop.
After taking a look at HADOOP-8037, I think your approach 1 makes more sense. In HADOOP-8037, the main reason to create platform (x64 vs amd64) dependent destinations was to accommodate Linux packaging requirements. On Linux, we have install scripts that will install the binaries to different destinations (/usr/lib vs /usr/lib64) and set java.library.path accordingly in .deb and .rpm packages. On Windows, we don't do such things, and it makes more sense to use 'package' settings, i.e. put the binary under 'lib/native'. Also the platform is already part of the path, so there will be no confusing.
I still need to create a packageBinNativeHadoop.py because [Ant exec|http://ant.apache.org/manual/Tasks/exec.html] does not support 'if' condition.
I have tested building on Windows and Ubuntu, and both passes.
> Remove sh dependency of bin-package target
> ------------------------------------------
>
> Key: HADOOP-9609
> URL: https://issues.apache.org/jira/browse/HADOOP-9609
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Chuan Liu
> Assignee: Chuan Liu
> Priority: Minor
> Attachments: HADOOP-9609-branch-1-win-2.patch, HADOOP-9609-branch-1-win.patch
>
>
> In Ant package target, we no longer use packageBinNativeHadoop.sh to place native library binaries. However, the same script is still present in the bin-package target. We should remove bin-package target's dependency on sh to keep it consistent with package target.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira